Skip to content

Library support for aarch64-unknown-linux-pauthtest target#156548

Open
jchlanda wants to merge 17 commits into
rust-lang:mainfrom
jchlanda:jakub/pac_lib
Open

Library support for aarch64-unknown-linux-pauthtest target#156548
jchlanda wants to merge 17 commits into
rust-lang:mainfrom
jchlanda:jakub/pac_lib

Conversation

@jchlanda
Copy link
Copy Markdown

@jchlanda jchlanda commented May 13, 2026

This is a follow up to #155722, adding library support for the target.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 13, 2026
@jchlanda
Copy link
Copy Markdown
Author

jchlanda commented May 13, 2026

The relevant change is only in the two most recent commits, the rest is from the target introduction PR.

This was referenced May 13, 2026
Open
Open
@jchlanda
Copy link
Copy Markdown
Author

jchlanda commented May 18, 2026 •
edited
Loading

@davidtwco, @folkertdev, @tgross35, @madsmtm FWI this is a follow up to #155722
This will have to be rebased once #155722 is merged.

@jchlanda jchlanda marked this pull request as ready for review May 19, 2026 12:16
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 19, 2026

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The GCC codegen subtree was changed

cc @antoyo, @GuillaumeGomez

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 19, 2026

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@jchlanda jchlanda mentioned this pull request May 19, 2026
Open
@rustbot

This comment has been minimized.

Sign in to view
@jchlanda jchlanda mentioned this pull request May 27, 2026
Open
@jchlanda jchlanda mentioned this pull request Jun 1, 2026
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jchlanda jchlanda force-pushed the jakub/pac_lib branch 2 times, most recently from e1660b3 to b56662b Compare June 1, 2026 15:06
@rust-bors

This comment has been minimized.

Sign in to view
jchlanda and others added 16 commits June 3, 2026 13:42
@jchlanda @kovdan01
Introduce aarch64-unknown-linux-pauthtest
0ad3bc9 
Co-authored-by: Daniil Kovalev <dkovalev@accesssoftek.com>
@jchlanda
New signature of get_fn_addr, teach Rust how to sign fn pointers
9a37be6 
Allow PAC metadata to be passed to `get_fn_addr` and related API
changes.
@jchlanda
Add pauth attributes and first IR tests
b08d331 
The set of supported attributes is:
function
* "aarch64-jump-table-hardening"
* "ptrauth-auth-traps"
* "ptrauth-calls"
* "ptrauth-indirect-gotos"
* "ptrauth-returns"
module
* "ptrauth-elf-got"
* "ptrauth-sign-personality"
@jchlanda
Add support for init/fini signing and correctly sign extern weak globals
927dcc4 
Also add flag for ELF-GOT signing.
@jchlanda
Teach bootstrap how to build rust_test_helpers for pauthtest
aadc196 
Also:
* update tests to force dynamic library when targetting pauthtest
* various test fixes
* introduce end-to-end tests for pauthtest (in run-make)
@jchlanda
Override static libraries and warn on linking against that kind of libs
bbcab8b
@jchlanda
Correctly set f128 math support for pauthtest
4b95452
@jchlanda
Use target_env = "musl" & target_abi = "pauthtest"
78ffb3d
@jchlanda
PR feedback: Introduce
0132d3f
@jchlanda
PR feedback: Attributes
6952603
@jchlanda
PR feedback: Init/Fini
5e9f0b9
@jchlanda
PR feedback: Teach bootstrap
4f72ead
@jchlanda
PR feedback: Override static
1a8e2e8
@jchlanda
PR feedback: Use target_env
f4a530d
@jchlanda
Add library support for aarch64-unknown-linux-pauthtest
f3f29ec
@jchlanda
Use target_env = "musl" & target_abi = "pauthtest" instead of env
ade83e7
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 3, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 3, 2026

☔ The latest upstream changes (presumably #157376) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@folkertdev folkertdev

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jchlanda @rustbot @rust-log-analyzer @folkertdev