rustdoc: Only synthesize auto/blanket impls for documented items - #159779
Conversation
|
This is based on #159721, so this should be rebased and get a perf run once that PR lands. |
Previously, the code would skip synthesizing impls if the *trait* was not documented, but it would still synthesize even if the *type* was not documented. This is wasted work.
b240756 to
ab70c36
Compare
|
rustbot has assigned @GuillaumeGomez. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustdoc: Only synthesize auto/blanket impls for documented items
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (8d0c82f): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.6%, secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -7.4%, secondary -6.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 488.662s -> 489.706s (0.21%) |
|
Another great improvement, thanks a lot! @bors r+ p=6 rollup=never |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 89c61a7 (parent) -> 76c35a1 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 76c35a14a45897a366c11657ecbbe9ec4153ad17 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (76c35a1): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.8%, secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -7.4%, secondary -3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 487.226s -> 488.274s (0.22%) |
Previously, the code would skip synthesizing impls if the trait was
not documented, but it would still synthesize even if the type was not
documented. This is wasted work.