Initial refactor of InferCtxt towards unified type checking state and per item side tables - #26582
Merged
Merged
Conversation
Contributor
|
Placing |
Collaborator
|
☔ The latest upstream changes (presumably #26415) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
r+ from me once we resolve nits, get things building |
6 tasks
jroesch
force-pushed
the
infer-ctxt-refactor
branch
3 times, most recently
from
June 26, 2015 19:23
4025071 to
57f8253
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 57f8253 has been approved by |
Collaborator
|
☔ The latest upstream changes (presumably #26575) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
🔒 Merge conflict |
This first patch starts by moving around pieces of state related to type checking. The goal is to slowly unify the type checking state into a single typing context. This initial patch moves the ParameterEnvironment into the InferCtxt and moves shared tables from Inherited and ty::ctxt into their own struct Tables. This is the foundational work to refactoring the type checker to enable future evolution of the language and tooling.
jroesch
force-pushed
the
infer-ctxt-refactor
branch
from
June 27, 2015 21:51
57f8253 to
fd412ab
Compare
Contributor
There was a problem hiding this comment.
This looks like a rebase mishap (this function is gone on master, moved to ctxt::create_and_enter).
jroesch
force-pushed
the
infer-ctxt-refactor
branch
from
June 28, 2015 09:44
fd412ab to
15bc4a3
Compare
Contributor
|
@bors r=nikomatsakis p=1 |
Collaborator
|
📌 Commit 15bc4a3 has been approved by |
Collaborator
|
⌛ Testing commit 15bc4a3 with merge 84855fe... |
bors
added a commit
that referenced
this pull request
Jun 28, 2015
This branch begins the work of unifying our type checking contexts into a single piece of state. The goal is to eventually have a single context that we can pass around instead of the fractured situation we currently have. There are still several things that must be done before beginning to make tables item local: - [ ] move FulfillmentContext into InferCtxt - [ ] modify SelectionContext to only take a single context argument - [ ] remove remaining typer impls - [ ] remove the ClosureTyper + Typer trait - [ ] do some renaming to make these things more applicable to their new roles r? @nikomatsakis As a side note there are a couple oddities that are temporary refactors that will be quickly cleaned up in a follow-up PR. cc @eddyb @Aatch @arielb1 @nrc
Collaborator
|
💔 Test failed - auto-mac-32-opt |
Contributor
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit 5c3753f has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 29, 2015
This branch begins the work of unifying our type checking contexts into a single piece of state. The goal is to eventually have a single context that we can pass around instead of the fractured situation we currently have. There are still several things that must be done before beginning to make tables item local: - [ ] move FulfillmentContext into InferCtxt - [ ] modify SelectionContext to only take a single context argument - [ ] remove remaining typer impls - [ ] remove the ClosureTyper + Typer trait - [ ] do some renaming to make these things more applicable to their new roles r? @nikomatsakis As a side note there are a couple oddities that are temporary refactors that will be quickly cleaned up in a follow-up PR. cc @eddyb @Aatch @arielb1 @nrc
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch begins the work of unifying our type checking contexts into a single piece of state. The goal is to eventually have a single context that we can pass around instead of the fractured situation we currently have. There are still several things that must be done before beginning to make tables item local:
r? @nikomatsakis
As a side note there are a couple oddities that are temporary refactors that will be quickly cleaned up in a follow-up PR.
cc @eddyb @Aatch @arielb1 @nrc