Skip to content

Rename 'librustc_unicode' crate to 'libstd_unicode'. - #38049

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:libunicode
Dec 12, 2016
Merged

Rename 'librustc_unicode' crate to 'libstd_unicode'.#38049
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:libunicode

Conversation

@frewsxcv

Copy link
Copy Markdown
Contributor

Fixes #26554.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv mentioned this pull request Nov 28, 2016
@Kimundi Kimundi added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 28, 2016

@Kimundi Kimundi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine so far - question is just if unicode is maybe a too general name for its std-specific purpose.

@alexcrichton

Copy link
Copy Markdown
Member

Discussed a bit during triage and conclusion was that a name like std_unicode is the way to go now, we're not quite ready to take the sweet unicode name yet.

@frewsxcv

Copy link
Copy Markdown
Contributor Author

Discussed a bit during triage and conclusion was that a name like std_unicode is the way to go now

Changes have been made in the latest force push.

@frewsxcv frewsxcv changed the title Rename 'librustc_unicode' crate to 'libunicode'. Rename 'librustc_unicode' crate to 'libstd_unicode'. Nov 29, 2016
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Nov 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit c904a36 has been approved by alexcrichton

@ollie27

ollie27 commented Nov 30, 2016

Copy link
Copy Markdown
Contributor

Presumably the Makefiles will need to be updated as well. This was attempted before: #36806.

@frewsxcv

Copy link
Copy Markdown
Contributor Author

Presumably the Makefiles will need to be updated as well.

Good catch. Fixed in the latest force push. r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon Nov 30, 2016
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 274777a has been approved by alexcrichton

@frewsxcv

frewsxcv commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

@bors r=-50

This is not super important. Doesn't need to be prioritized.

@bors

bors commented Dec 1, 2016

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Dec 1, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 274777a has been approved by -50

@frewsxcv

frewsxcv commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

@bors r=alexcrichton p=-50

@bors

bors commented Dec 1, 2016

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Dec 1, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 274777a has been approved by alexcrichton

@nagisa

nagisa commented Dec 2, 2016

Copy link
Copy Markdown
Member

AFAIR according to #24428, the rustc_unicode crate is supposed to be a facade for the compiler itself? In that case rustc_unicode makes very much sense to me.

@Kimundi

Kimundi commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

std uses it as well though, and the compiler uses std, so the dependency chain works out as "compiler using a part of the std lib", which makes more sense than what the current name implies, which is "std uses part of the compiler lib".

@bors

bors commented Dec 12, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 274777a with merge b4b1e5e...

bors added a commit that referenced this pull request Dec 12, 2016
Rename 'librustc_unicode' crate to 'libstd_unicode'.

Fixes #26554.
@bors
bors merged commit 274777a into rust-lang:master Dec 12, 2016
@bors bors mentioned this pull request Dec 12, 2016
2 tasks
@frewsxcv
frewsxcv deleted the libunicode branch December 12, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api [DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants