Parse external source mods in normal .rs files - #4003
Closed
brson wants to merge 59 commits into
Closed
Conversation
I actually already pushed most of this by accident before I meant to, but r=nmatsakis anyway. Closes rust-lang#3953
Note that the function versions were already pure.
This closes rust-lang#3782.
escape functions in char, io.with_str_reader, base64 and md5sum, cell.empty_cell and is_empty.
Conflicts: src/libsyntax/ext/source_util.rs
Makes the public API much easier to see and prepares the way for making them pure.
Note that the function versions were already pure.
This closes rust-lang#3782.
escape functions in char, io.with_str_reader, base64 and md5sum, cell.empty_cell and is_empty.
Merge branch 'feature/purity' of github.com:jesse99/rust into feature/purity
Added support for options that take no arguments and may be repeated.
Contributor
Author
|
r=pcwalton |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Nov 10, 2024
Fixed a typo in the GetThreadDescription shim
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4029: Fix various proc-macro bugs r=matklad a=edwin0cheng This PRs does the following things: 1. Fixed rust-lang#4001 by splitting `LIFETIME` lexer token to two mbe tokens. It is because rustc token stream expects `LIFETIME` as a combination of punct and ident, but RA `tt:TokenTree` treats it as a single `Ident` previously. 2. Fixed rust-lang#4003, by skipping `proc-macro` for completion. It is because currently we don't have `AstNode` for `proc-macro`. We would need to redesign how to implement `HasSource` for `proc-macro`. 3. Fixed a bug how empty `TokenStream` merging in `proc-macro-srv` such that no L_DOLLAR and R_DOLLAR will be emitted accidentally. Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2176
I need this snapshotted. It adds the ability to parse
mod foo;from an external file.I have no idea why github decided to include so many commits in this pull (oh, it's because the pull request is against master, not incoming). The relevant commit is brson@72cc1ac