librustc: Implement &static as the replacement for Durable - #4409
Closed
pcwalton wants to merge 3 commits into
Closed
librustc: Implement &static as the replacement for Durable#4409pcwalton wants to merge 3 commits into
&static as the replacement for Durable#4409pcwalton wants to merge 3 commits into
Conversation
Contributor
|
Based on the title of the pull request I presume you only wanted me to look at f74a480... looks good, my one comment is that maybe you convert the existing tests that use Durable to use &static? If you do that, then r=nmatsakis |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 28, 2025
Automatic Rustup
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4409: Hot fix panic for function_signature r=edwin0cheng a=edwin0cheng I am totally agree this comment: https://github.com/rust-analyzer/rust-analyzer/blob/f1cb5b8a29ce509bf1f8d6df97d4b6586b9a2dac/crates/ra_ide/src/display/function_signature.rs#L3-L4 But let hot fix all panic for right now, it is so disturbing when browsing code... Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis