Format asm! macro calls - #5191
Closed
ytmimi wants to merge 1 commit into
Closed
Conversation
ytmimi
force-pushed
the
feature/format_asm_macro
branch
3 times, most recently
from
January 28, 2022 15:05
fbe8494 to
713ae48
Compare
ytmimi
marked this pull request as draft
January 28, 2022 15:45
ytmimi
force-pushed
the
feature/format_asm_macro
branch
from
January 29, 2022 21:33
713ae48 to
3f23b89
Compare
4 tasks
ytmimi
force-pushed
the
feature/format_asm_macro
branch
from
February 1, 2022 01:54
3f23b89 to
b3ae0ef
Compare
calebcartwright
self-requested a review
February 2, 2022 01:37
ytmimi
marked this pull request as ready for review
February 27, 2022 02:28
ytmimi
added
pr-merge-conflict
Collaborator
|
☔ The latest upstream changes (possibly #6823) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Going to close this for now. It's been open for a while without any progress, but maybe we'll pick this back up in the future once style rules are finalized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for formatting
asm!macro calls.Formatting for
asm!is gated behind a new unstableforamt_asm_macroconfiguration value.Tracking issue for the new configuration value can be found at #5210
The specific guidelines for formatting the macro are still being decided, but this PR goes a long way to formatting the various components of the
asm!macro (templates, operands, clobber_abis, and options).