Skip to content

Add wg-const-eval team - #332

Merged
nikomatsakis merged 4 commits into
rust-lang:masterfrom
ecstatic-morse:const-eval
Jun 12, 2020
Merged

Add wg-const-eval team#332
nikomatsakis merged 4 commits into
rust-lang:masterfrom
ecstatic-morse:const-eval

Conversation

@ecstatic-morse

Copy link
Copy Markdown
Contributor

...with @oli-obk and @RalfJung as co-leads and myself as a member. I don't think this implies any additional level of commitment from the two leads, it's just a reflection of seniority.

We might need to block this on me reviving rust-lang/compiler-team#201? Not sure what the process is here.

r? @XAMPPRocky
(since they requested this on Zulip)

Comment thread teams/wg-const-eval.toml Outdated
@RalfJung

Copy link
Copy Markdown
Member

Fine for me, thanks for taking initiative! Since I am not very familiar with some aspects of const-eval, in particular the static checks, I'd also be fine with @oli-obk as the sole lead. My involvement here is mainly through Miri, and to lend my theoretical and PL research experience for matters of const-soundness (as reflected in our dynamic checks). But the further we move from the Miri engine to the rest of rustc, the less familiar I am with the territory. ;)

But maybe leads don't have to know everything, then that's okay with me as well. :D

Comment thread teams/wg-const-eval.toml Outdated
@XAMPPRocky

XAMPPRocky commented May 1, 2020

Copy link
Copy Markdown
Contributor

@ecstatic-morse LGTM, minus the small nit above. Thanks for making the PR, if the group needs or wants shared permissions on repos such as miri you can add the following. I can't merge the PR (only core can merge on team).

[permission]
bors.miri.review = true

@RalfJung

RalfJung commented May 1, 2020

Copy link
Copy Markdown
Member

There's a dedicated Miri team/WG already, I don't think const-eval needs any extra permissions (well maybe r+ for rustc itself but we all already have that from elsewhere).

@oli-obk

oli-obk commented May 1, 2020

Copy link
Copy Markdown
Contributor

Yea, miri is independent from const eval. While miri-engine decisions made for const eval affect miri, that's like any teams decisions having effects on other teams, so that's fine.

@RalfJung

RalfJung commented May 1, 2020

Copy link
Copy Markdown
Member

Also the Miri and cosnt-eval teams have good communication as they are 66% the same people. ;)

@ecstatic-morse

Copy link
Copy Markdown
Contributor Author

I updated the title @XAMPPRocky. rust-lang/const-eval doesn't use bors (there's no rust code), and that's the only repo that's managed by this working group.

Comment thread teams/wg-const-eval.toml Outdated
repo = "https://github.com/rust-lang/const-eval"

[github]
orgs = ["rust-lang", "rust-lang-nursery"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to have this team on the nursery?

@ecstatic-morse

Copy link
Copy Markdown
Contributor Author

Closing due to inactivity. I was explicitly asked to do this, so I'm not sure what the deal is.

@RalfJung

Copy link
Copy Markdown
Member

No need to be snappy, probably it just dropped off of someone's radar. Just ping someone who can hopefully push this forward. :)
There's also an unanswered question.

@XAMPPRocky @pietroalbini what does it take to land this?

@XAMPPRocky

Copy link
Copy Markdown
Contributor

The PR has been good to merge for me, I don't have merge access to team. It has to be done by a core team member.

@RalfJung

Copy link
Copy Markdown
Member

@ecstatic-morse can you reopen the PR? I can take care of pushing it through.

@emilyalbini emilyalbini reopened this Jun 12, 2020
@emilyalbini

Copy link
Copy Markdown
Member

r? @nikomatsakis @pnkfelix as the leads of the compiler team.

Comment thread teams/wg-const-eval.toml Outdated

@nikomatsakis nikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @ecstatic-morse I didn't see this PR at all until now :)

@nikomatsakis
nikomatsakis merged commit 6f5eee9 into rust-lang:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants