Add wg-const-eval team - #332
Conversation
d9cb010 to
5d04495
Compare
|
Fine for me, thanks for taking initiative! Since I am not very familiar with some aspects of const-eval, in particular the static checks, I'd also be fine with @oli-obk as the sole lead. My involvement here is mainly through Miri, and to lend my theoretical and PL research experience for matters of const-soundness (as reflected in our dynamic checks). But the further we move from the Miri engine to the rest of rustc, the less familiar I am with the territory. ;) But maybe leads don't have to know everything, then that's okay with me as well. :D |
|
@ecstatic-morse LGTM, minus the small nit above. Thanks for making the PR, if the group needs or wants shared permissions on repos such as miri you can add the following. I can't merge the PR (only core can merge on [permission]
bors.miri.review = true |
|
There's a dedicated Miri team/WG already, I don't think const-eval needs any extra permissions (well maybe r+ for rustc itself but we all already have that from elsewhere). |
|
Yea, miri is independent from const eval. While miri-engine decisions made for const eval affect miri, that's like any teams decisions having effects on other teams, so that's fine. |
|
Also the Miri and cosnt-eval teams have good communication as they are 66% the same people. ;) |
|
I updated the title @XAMPPRocky. rust-lang/const-eval doesn't use bors (there's no rust code), and that's the only repo that's managed by this working group. |
| repo = "https://github.com/rust-lang/const-eval" | ||
|
|
||
| [github] | ||
| orgs = ["rust-lang", "rust-lang-nursery"] |
There was a problem hiding this comment.
Is there any reason to have this team on the nursery?
|
Closing due to inactivity. I was explicitly asked to do this, so I'm not sure what the deal is. |
|
No need to be snappy, probably it just dropped off of someone's radar. Just ping someone who can hopefully push this forward. :) @XAMPPRocky @pietroalbini what does it take to land this? |
|
The PR has been good to merge for me, I don't have merge access to team. It has to be done by a core team member. |
|
@ecstatic-morse can you reopen the PR? I can take care of pushing it through. |
|
r? @nikomatsakis @pnkfelix as the leads of the compiler team. |
nikomatsakis
left a comment
There was a problem hiding this comment.
Sorry @ecstatic-morse I didn't see this PR at all until now :)
...with @oli-obk and @RalfJung as co-leads and myself as a member. I don't think this implies any additional level of commitment from the two leads, it's just a reflection of seniority.
We might need to block this on me reviving rust-lang/compiler-team#201? Not sure what the process is here.
r? @XAMPPRocky
(since they requested this on Zulip)