Skip to content

Extend the reference team to the lang-docs team - #445

Merged
nikomatsakis merged 1 commit into
rust-lang:masterfrom
JohnTitor:lang-docs
Oct 15, 2020
Merged

Extend the reference team to the lang-docs team#445
nikomatsakis merged 1 commit into
rust-lang:masterfrom
JohnTitor:lang-docs

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

As mentioned in #443, this extends the reference team to the lang-docs team.
This is the first step, we could add folks interested in maintaining the docs later.
Added myself to the leads as a maintainer of the nomicon.

Closes #443

cc @rust-lang/lang, and @ehuss as they maintain the docs submodules on rust-lang/rust.

@emilyalbini

Copy link
Copy Markdown
Member

Note that deploying this will need someone with admin permissions to first rename the team on the GitHub interface, otherwise we'll lose all permissions configured in the repositories: sync-team doesn't handle renames, it just removes and then recreates the team.

@JohnTitor

Copy link
Copy Markdown
Member Author

@pietroalbini If my understanding is correct, the current "reference" team doesn't use sync-team as it doesn't have the [[github]] orgs = ["rust-lang"] section, right?

@JohnTitor

Copy link
Copy Markdown
Member Author

But yeah, we could archive the reference team then create a fresh team if it's desirable.

@emilyalbini

Copy link
Copy Markdown
Member

@JohnTitor I think the best solution is for someone to rename the old team to the new one before merging this PR, and then merge this as-is once someone from the lang team approves the changes.

@JohnTitor

Copy link
Copy Markdown
Member Author

@pietroalbini

for someone to rename the old team to the new one before merging this PR

You mean the team is on GitHub? We don't have the reference team on the GitHub teams AFAIK.

@emilyalbini

Copy link
Copy Markdown
Member

Sorry, you're right :)

Then this PR is fine to merge as soon as someone from lang acks.

@JohnTitor

Copy link
Copy Markdown
Member Author

On #443, Josh and Taylor from the lang added 👍 so we could say this got some approvals?

The core team (i.e. org owner) only can merge this and set up for repository permission so could I ask @nikomatsakis as a core and lead of the lang to do that?

@nikomatsakis

Copy link
Copy Markdown
Contributor

Looks great!

@nikomatsakis
nikomatsakis merged commit cbc2d3e into rust-lang:master Oct 15, 2020
@JohnTitor
JohnTitor deleted the lang-docs branch October 15, 2020 18:30
Comment thread teams/lang-docs.toml
[website]
name = "lang-docs team"
description = "Developing and writing the docs related to the lang team"
zulip-stream = "t-lang/docs"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is broken. The zulip stream is t-lang/doc.

@JohnTitor JohnTitor Oct 15, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks. Will fix it soon.
EDIT: Opened #454.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up for the t-lang/doc team

4 participants