Remove features "nightly", "small_rng"; remove old deprecated code - #1732
Merged
Conversation
dhardy
changed the title
dhardy
force-pushed
the
push-ukptzvsszylo
branch
from
February 4, 2026 08:53
e25260b to
410bc26
Compare
dhardy
force-pushed
the
push-ukptzvsszylo
branch
from
February 4, 2026 09:21
410bc26 to
74fa1b4
Compare
dhardy
changed the title
newpavlov
approved these changes
Feb 4, 2026
| ### Removals | ||
| - Removed `ReseedingRng` ([#1722]) | ||
| - Removed unused feature "nightly" ([#1732]) | ||
| - Removed feature `small_rng` ([#1732]) |
Member
There was a problem hiding this comment.
Mention removed deprecated items.
Member
Author
There was a problem hiding this comment.
The removal (or rename) was mentioned previously, so I don't see the need.
ndren
added a commit
to ndren/uiua
that referenced
this pull request
Feb 15, 2026
kaikalii
added a commit
to uiua-lang/uiua
that referenced
this pull request
Feb 15, 2026
* set version to 0.19 * deterministic gen? * gen determinism test * move gen tests to correct dyadic file * use u64 instead of usize to hash shape * update rand to 0.10.0, remove deleted smallrng feature rust-random/rand#1732 * cleanup rand version spec * update site getrandom * add multidimensional gen test * fix: use standard test order --------- Co-authored-by: Kai Schmidt <kaikaliischmidt@gmail.com>
This was referenced Jul 27, 2026
bherrera
pushed a commit
to misttech/fuchsia
that referenced
this pull request
Aug 26, 2026
This removes the `small_rng` feature, which was removed in rust-random/rand#1732. Depends-On: turquoise-internal:I8ed8d19ab00efa338c0f1f4ade9157b23035a142 Change-Id: I14286c3b5ca70719cab355a294cd1a84b910c827 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1766753 Reviewed-by: Josh Gargus <jjosh@google.com> Fuchsia-Auto-Submit: Erick Tryzelaar <etryzelaar@google.com> Reviewed-by: Claire Gonyeo <cgonyeo@google.com> Commit-Queue: Erick Tryzelaar <etryzelaar@google.com> Reviewed-by: Eric Rinehart <erinehart@google.com> Reviewed-by: Abdulla Kamar <abdulla@google.com> Reviewed-by: Thomas Zander <thomasalpinus@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Dependencies-Satisfied: cl-deps-checker@fuchsia-internal-service-accts.iam.gserviceaccount.com <cl-deps-checker@fuchsia-internal-service-accts.iam.gserviceaccount.com> Reviewed-by: Josh Liebow-Feeser <joshlf@google.com> Reviewed-by: Adrian Danis <adanis@google.com> Reviewed-by: Erick Tryzelaar <etryzelaar@google.com> Owners-Override: Adam Barth <abarth@google.com> Reviewed-by: Steven Grady <slgrady@google.com> Reviewed-by: Onath Dillinger <claridge@google.com> Reviewed-by: Bruno Dal Bo <brunodalbo@google.com> Reviewed-by: Caroline Liu <carolineliu@google.com> Reviewed-by: Étienne J. Membrives <etiennej@google.com> Reviewed-by: Adam Barth <abarth@google.com> Reviewed-by: Jiaming Li <lijiaming@google.com> Reviewed-by: Chris Drouillard <cdrllrd@google.com>
bherrera
pushed a commit
to misttech/fuchsia
that referenced
this pull request
Aug 26, 2026
This reverts commit 559e925. Reason for revert: Reverting suspect CL due to builder failure Failure Link: go/bbid/8672827297979916433 Original change's description: > [rust-3p] Update rand to 0.10.2, rand_xorshift to 0.5.0 > > This removes the `small_rng` feature, which was removed in > rust-random/rand#1732. > > Depends-On: turquoise-internal:I8ed8d19ab00efa338c0f1f4ade9157b23035a142 > Change-Id: I14286c3b5ca70719cab355a294cd1a84b910c827 > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1766753 > Reviewed-by: Josh Gargus <jjosh@google.com> > Fuchsia-Auto-Submit: Erick Tryzelaar <etryzelaar@google.com> > Reviewed-by: Claire Gonyeo <cgonyeo@google.com> > Commit-Queue: Erick Tryzelaar <etryzelaar@google.com> > Reviewed-by: Eric Rinehart <erinehart@google.com> > Reviewed-by: Abdulla Kamar <abdulla@google.com> > Reviewed-by: Thomas Zander <thomasalpinus@google.com> > SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> > Dependencies-Satisfied: cl-deps-checker@fuchsia-internal-service-accts.iam.gserviceaccount.com <cl-deps-checker@fuchsia-internal-service-accts.iam.gserviceaccount.com> > Reviewed-by: Josh Liebow-Feeser <joshlf@google.com> > Reviewed-by: Adrian Danis <adanis@google.com> > Reviewed-by: Erick Tryzelaar <etryzelaar@google.com> > Owners-Override: Adam Barth <abarth@google.com> > Reviewed-by: Steven Grady <slgrady@google.com> > Reviewed-by: Onath Dillinger <claridge@google.com> > Reviewed-by: Bruno Dal Bo <brunodalbo@google.com> > Reviewed-by: Caroline Liu <carolineliu@google.com> > Reviewed-by: Étienne J. Membrives <etiennej@google.com> > Reviewed-by: Adam Barth <abarth@google.com> > Reviewed-by: Jiaming Li <lijiaming@google.com> > Reviewed-by: Chris Drouillard <cdrllrd@google.com> Change-Id: I350437ef38553510a5b703f5c1fe0994445b3e27 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1776633 Fuchsia-Auto-Submit: Jiaming Li <lijiaming@google.com> Reviewed-by: Steven Grady <slgrady@google.com> Reviewed-by: Jiaming Li <lijiaming@google.com> Exempt: android-build-ayeaye@system.gserviceaccount.com <android-build-ayeaye@system.gserviceaccount.com> Commit-Queue: Erick Tryzelaar <etryzelaar@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentryThis feature is unused.
Old deprecated code (from v0.9.0) is removed. More recently deprecations have never been published (though "since" said 0.9.2, the changes have not yet been published), hence I bumped the "since" version to 0.10.0.
Removes the "small_rng" feature since I can't think of a single reason to keep it. (Marginally faster builds?) I tested the size of
examples/monte-carlo.rswith/without this, and in debug builds disabling the feature saved 16B (of ~5MiB) while release builds saved 0B (using themoldlinker). (See also #1419.)