Repository navigation
Return restore I/O errors instead of panicking - #575
Open
magrathean-uk wants to merge 1 commit into
Open
magrathean-uk wants to merge 1 commit into
magrathean-uk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore currently unwraps pack reads and destination operations, so a persistent backend error or a full destination disk can panic. Return a structured error instead; readable packs can continue when one pack read fails, while a destination write failure stops further writes.
Related issues: rustic-rs/rustic#564 and rustic-rs/rustic#1914
Validation: the storage-full unit test and missing-pack integration test each passed on this clean main-based branch. The combined core library suite passed 172 tests, and the focused integration regressions passed there too. A real full-disk device and live remote backend were not used.