Skip to content

Tell Mattermost operators when the bridge account needs email verification - #2141

Open
rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:fix/mattermost-email-verification-hint
Open

rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:fix/mattermost-email-verification-hint

Conversation

@rudycelekli

Copy link
Copy Markdown

What this changes

Addresses the sign-in diagnostics in #2113. Mattermost returns a distinct HTTP 401 error when the bridge account needs email verification. Switch funnels it into the password-error message. Preserve the error ID at the Mattermost HTTP boundary and tell the operator to verify the bridge account's email and retry. Other login errors still use their existing treatment.

Mattermost emits this error ID for unverified accounts.

How it was tested

  • Reproduced the generic password hint on main with an HTTP 401 fixture using the Mattermost error ID and a localized message.
  • 295 Mattermost and platform credential tests passed, including the real PostgreSQL-backed cases on isolated PostgreSQL 18.6. The regular Docker fixture could not start on this host, so PostgreSQL was provided by an external fixture.
  • Repository-wide Ruff and core mypy passed. Full Docker validation and a live Mattermost deployment were unrun.

Codex assisted with the patch and tests.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment on this pull request:


Contributing on behalf of a company? Your employer can sign the Corporate CLA instead: complete the PDF with your authorized GitHub usernames, have an authorized representative sign it, and email it to legal@sandboxquantum.com. Once we record it, your contributions are recognized as covered — see CONTRIBUTING.md.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant