Skip to content

Use the configured Mattermost IPv6 address and reverse-proxy subpath - #2144

Open
rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:fix/mattermost-driver-server-urls
Open

rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:fix/mattermost-driver-server-urls

Conversation

@rudycelekli

Copy link
Copy Markdown

What this changes

Mattermost's connector validation accepts bracketed IPv6 URLs and server subpaths. Driver construction splits the host and port by hand, so a bracketed IPv6 address without a port raises an exception and a reverse-proxy subpath is put before the port instead of after it. Use the same URL parser as validation, preserve the server subpath, and retain the driver's existing port defaults.

How it was tested

  • Two new driver URL regressions failed on main. Both now pass, along with coverage for explicit and default legacy HTTP ports.
  • All 319 Mattermost adapter and workspace claim tests passed using isolated PostgreSQL 18.6 in place of the unavailable Docker fixture.
  • A real IPv6 loopback HTTP server received the driver's request at the expected subpath.
  • Repository-wide Ruff and core mypy passed. The full Docker suite and a live Mattermost deployment were unrun.

Codex assisted with the patch and regression tests.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment on this pull request:


Contributing on behalf of a company? Your employer can sign the Corporate CLA instead: complete the PDF with your authorized GitHub usernames, have an authorized representative sign it, and email it to legal@sandboxquantum.com. Once we record it, your contributions are recognized as covered — see CONTRIBUTING.md.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant