Skip to content

Preserve the room creation visibility notice - #2151

Open
rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:feat/persist-room-creation-visibility-notice
Open

rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:feat/persist-room-creation-visibility-notice

Conversation

@rudycelekli

Copy link
Copy Markdown

Part of #2124.

When Switch makes a public channel because a creator without a linked account omitted the visibility choice, its explanation only appears among attachment outcomes. Persist a historical explanation on the room and expose it separately as creation_visibility_notice in the Gateway room detail and the agent's creation result. The tool description and room skill tell the agent to relay it. A later viewer learns why the room was created that way without the notice making any claim about their own account. Existing creation and attachment fields remain available.

This supplies an API field for a durable room warning. A visible desktop banner remains part of #2124.

Three test cases reproduced the lost explanation on main. All 51 focused creation, detail, Gateway and tool tests passed on macOS with isolated PostgreSQL 18.6. Full Ruff format/lint and mypy passed. The full Docker-backed test suite was not run.

Codex assisted with implementation and validation.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment on this pull request:


Contributing on behalf of a company? Your employer can sign the Corporate CLA instead: complete the PDF with your authorized GitHub usernames, have an authorized representative sign it, and email it to legal@sandboxquantum.com. Once we record it, your contributions are recognized as covered — see CONTRIBUTING.md.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant