Repository navigation
Preserve the room creation visibility notice - #2151
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
|
Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment on this pull request: Contributing on behalf of a company? Your employer can sign the Corporate CLA instead: complete the PDF with your authorized GitHub usernames, have an authorized representative sign it, and email it to legal@sandboxquantum.com. Once we record it, your contributions are recognized as covered — see CONTRIBUTING.md. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
rudycelekli
marked this pull request as ready for review
November 18, 2026 16:14
rudycelekli
requested review from
abeldantas,
agent-runner353,
amaudruz,
christian-mcdermott,
lbangalosbt,
massimo-sandboxaq,
niall-sandboxaq,
petr-sandbox,
raullopez-sandbox and
simonflk-sb
as code owners
November 18, 2026 16:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2124.
When Switch makes a public channel because a creator without a linked account omitted the visibility choice, its explanation only appears among attachment outcomes. Persist a historical explanation on the room and expose it separately as
creation_visibility_noticein the Gateway room detail and the agent's creation result. The tool description and room skill tell the agent to relay it. A later viewer learns why the room was created that way without the notice making any claim about their own account. Existing creation and attachment fields remain available.This supplies an API field for a durable room warning. A visible desktop banner remains part of #2124.
Three test cases reproduced the lost explanation on main. All 51 focused creation, detail, Gateway and tool tests passed on macOS with isolated PostgreSQL 18.6. Full Ruff format/lint and mypy passed. The full Docker-backed test suite was not run.
Codex assisted with implementation and validation.