[pedrobonamin]

Fixes #1699

Problem

When the locales option is set, sanity-plugin-media stores altText, title, description and creditLine as per-locale objects (altText: {en: "brass faucet", "zh-CN": "黄铜龙头"}). Search still queried the bare field (altText match '*faucet*'), and GROQ match never matches an object, so both the main search box and the "Alt text" / "Title" / "Description" / "Credit" facets returned nothing for localized values.

Reproduced with groq-js 2.0.0 against the filter constructFilter builds:

Query	Result
Reported query (bare altText)	["legacy"] — the localized asset is missing
Fixed main search	["localized", "legacy"]
Fixed "Alt text includes" facet	["localized", "legacy"]
zh-CN value 龙头	["localized"]

Fix

• constructFilter takes the configured localeIds. For the four localized fields, the main search and the includes / doesNotInclude facets match field["<localeId>"] for each locale alongside the bare field, so assets not yet migrated from a plain string keep matching.
• Bracket access is used on purpose: altText.zh-CN parses as subtraction in GROQ. Locale ids are JSON-quoted, deduplicated, and blank ids are skipped.
• Search text still goes through groqWildcardMatch (from fix(media): keep apostrophes in Media search queries #2082), so an apostrophe in a localized query stays inside one GROQ string.
• empty / notEmpty facets check the locale keys too, so a localized field counts as empty only when no configured locale has a value.
• Search reuses state.assets.localeIds, which title sort (feat(media): add sort by title (A to Z / Z to A) #2016) already fills from ToolOptionsContext → Browser → ReduxProvider. Fields that are never localized (e.g. originalFilename) are untouched.

Tests

• constructFilter.test.ts: localized main search, includes / doesNotInclude / empty / notEmpty facets, non-localized facets stay plain, locale id quoting, blank/duplicate ids, and an apostrophe inside a localized search literal.
• fetchEpic.test.ts: assetsFetchPageIndexEpic sends a query containing altText["en"] and altText["zh-CN"] when locales are configured.
• Apostrophe, quote, and backslash cases from fix(media): keep apostrophes in Media search queries #2082 still pass. Title-sort tests from feat(media): add sort by title (A to Z / Z to A) #2016 still pass.

Changeset: sanity-plugin-media patch.

Rebased onto current main. The conflict with #2016 was the shared localeIds wiring; search now reads the same ids title sort already stores.

  

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[changeset-bot]

🦋 Changeset detected

Latest commit: ce727c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sanity-plugin-media	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
plugins-studio	Ready	Preview	Oct 28, 2026 12:45pm UTC

1 Skipped Deployment

Project	Deployment	Actions	Updated
plugins-e2e-test-studio	Ignored		Oct 28, 2026 12:45pm UTC

[github-actions]

✅ E2E Tests

🟢 46 passed • view full report • view run

Studio: https://plugins-e2e-test-studio-qni8qb9xm.sanity.dev

Datasets: pr-2061-chromium-40689885120, pr-2061-firefox-40689885120

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	38.89%	7888 / 20281
🔵	Statements	38.85%	8486 / 21840
🔵	Functions	34.49%	2149 / 6230
🔵	Branches	31.13%	4605 / 14792

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
plugins/sanity-plugin-media/src/modules/assets/index.ts	86.11%	53.46%	84.17%	86.09%	126-128, 144-146, 178, 185, 245-250, 385, 392-393, 415-425, 444, 453, 466, 487, 571, 580-585, 590, 628-631, 649-652, 697, 727-736, 768-777, 812-820, 885-893, 920, 978
plugins/sanity-plugin-media/src/modules/uploads/index.ts	74.71%	36.84%	77.77%	74.41%	52, 56-61, 72-78, 141, 156-194, 239-243, 292-295
plugins/sanity-plugin-media/src/utils/constructFilter.ts	98.68%	89.09%	100%	98.52%	80

Generated in workflow #11442 for commit ce727c1 by the Vitest Coverage Report Action

[Copilot]

Copilot review overview

🟡 Changes recommended

Facet matching can incorrectly combine search terms across different translations.

Review effort: Balanced
Findings: 1

Open (1)

• Prevent cross-locale terms from satisfying multi-term facet matches · New

What changed in this PR

Adds locale-aware media search to address issue #1699.

Changes:

• Searches localized metadata fields in main search and facets.
• Threads locale IDs through Redux query generation.
• Adds regression tests and a patch changeset.

File	Description
.changeset/​media-localized-search.md	Documents the localized-search fix.
components/​Browser/​index.tsx	Passes configured locale IDs to Redux.
components/​ReduxProvider/​index.tsx	Stores locale IDs in initial state.
modules/​assets/​index.ts	Uses locale IDs for asset queries.
modules/​assets/​fetchEpic.test.ts	Tests locale-aware page fetching.
modules/​folders/​epics.test.ts	Updates test state fixtures.
modules/​uploads/​index.ts	Uses locale IDs in upload checks.
utils/​constructFilter.ts	Builds locale-aware GROQ filters.
utils/​constructFilter.test.ts	Tests localized search and facets.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[georgedoescode]

@pedrobonamin this makes sense, did we wanna solve the conflicts/comment above and get it in?

[cursor]

@georgedoescode rebased onto current main and pushed. The conflict with the title-sort change is resolved: search now uses the same localeIds that sort already stores. Ready for another look when you have a moment.