Is this broken in sbt 1.9.7?

[jakobmerrild]

We use this plugin to add a prometheus exporter. However, after upgrading to sbt version 1.9.7 it seems to no longer work.

Wondering if the plugin in general doesn't work with 1.9.7 or if there's something else wrong

Here's our build.sbt definition

javaAgents += JavaAgent(
  "io.prometheus.jmx" % "jmx_prometheus_javaagent" % "0.20.0",
  arguments = "${PROMETHEUS_PORT:-1936}:/app/prometheus-exporter.yaml"
)

[Marcus-Rosti]

I'll second this, I'm trying to get dd-agent-java working and it's not pulling it in

[Marcus-Rosti]

addSbtPlugin("org.typelevel" % "sbt-fs2-grpc" % "2.7.11")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.2")
addSbtPlugin("com.github.sbt" % "sbt-native-packager" % "1.9.16")
addSbtPlugin("com.github.sbt" % "sbt-javaagent" % "0.1.7")

with

lazy val server = project
  .in(file("server"))
  .enablePlugins(JavaServerAppPackaging, DockerPlugin, JavaAgent)
  .dependsOn(`protobuf`)
  .settings(
    name := "server",
    Compile / run / mainClass := Some("com.mrosti.Server"),
    dockerBaseImage := "amazoncorretto:21-alpine3.18",
    dockerExposedPorts ++= Seq(50051),
    javaAgents += "com.datadoghq" % "dd-java-agent" % "1.21.0",
...
)

[rlemaitre-ledger]

I have the same issue here with the opentelemetry agent. After upgrading to sbt 1.9.7, the agent is not passed to runtime.

The only difference in the generated script is

- addJava "-javaagent:${app_home}/../opentelemetry-javaagent/opentelemetry-javaagent-1.31.0.jar" 
+

[Marcus-Rosti]

It won't even download unless I put it at the top level of the multimodule build

ThisBuild / version := "0.1.0-SNAPSHOT"

ThisBuild / scalaVersion := "3.3.1"

enablePlugins(JavaAgent, DockerPlugin, AshScriptPlugin, JavaServerAppPackaging)
javaAgents += "com.datadoghq" % "dd-java-agent" % "1.21.0"

lazy val root = (project in file("."))
...
lazy val server (project in file("server"))

[Marcus-Rosti]

There's some bizarre interaction between native-packager, sbt, and javaagent

[eed3si9n]

Does everything work on sbt 1.9.6 but broken in sbt 1.9.7? If so it could be a regression in sbt. Is there a publicly available build that manifests this bug?

[Marcus-Rosti]

Cats breaks it?

[Marcus-Rosti]

@eed3si9n Here's a minimalish repro case: https://github.com/Marcus-Rosti/javaagent-bug

[info] Main Scala API documentation to /Users/mrosti/src/mrosti/javaagent-bug/app/target/scala-3.3.1/api...
[warn] -- Warning: core/jvm/src/main/scala/cats/effect/IOApp.scala:592:14 -------------
[warn] No DRI found for query: IOApp.Simple!.run:cats\.effect\.IO[Unit]*
[warn] one warning found
[warn] Following generated file paths might not be compatible with Jekyll:
[warn] _empty_/Main$
[warn] If using GitHub Pages consider adding a ".nojekyll" file.

[pvlugter]

Cats breaks it?
Here's a minimalish repro case: https://github.com/Marcus-Rosti/javaagent-bug

Won't be a cats dependency that breaks it. The example has this:

libraryDependencies := Seq(
  "org.typelevel" %% "cats-effect" % "3.5.2",
)

The plugin adds the agent to library dependencies, and the := is overriding that. Use ++= instead.

[pvlugter]

The bug here is that the javaagent is not being added to the native packager bashScriptExtraDefines. There's a dynamic dependency on JavaAppPackaging, but this setting is from BashStartScriptPlugin. So it will be that the order of auto plugins being applied has changed with sbt 1.9.7. @eed3si9n not a bug in sbt. I can update so the packaging plugin here also depends on BashStartScriptPlugin as it should.

[pvlugter]

Fix released in version 0.1.8.

[Marcus-Rosti]

thanks so much! I thought I was going crazy

[Marcus-Rosti]

I can confirm this worked