feat!: install every registered ubicloud ssh key on workers - #69
Merged
Conversation
The two key names kd installed on every worker were the author's own, so nobody else could create a usable worker without editing the source. Installing whatever keys the Ubicloud account has registered follows the account instead of the binary, and makes zero registered keys a preflight error rather than a worker nobody can reach. Test fixtures no longer carry the author's username or real tailnet user ids; those were never secrets, but a public repository has no reason to hold them. Breaking: workers now get all registered keys, not just ones named `laptop` and `devbox`, and `create` fails if the account has none.
scode
force-pushed
the
pr/ubiworker-all-ssh-keys
branch
from
August 22, 2026 16:00
1da6c73 to
ef074f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two key names kd installed on every worker were the author's own, so
nobody else could create a usable worker without editing the source.
Installing whatever keys the Ubicloud account has registered follows the
account instead of the binary, and makes zero registered keys a preflight
error rather than a worker nobody can reach.
Test fixtures no longer carry the author's username or real tailnet user
ids; those were never secrets, but a public repository has no reason to
hold them.
Breaking: workers now get all registered keys, not just ones named
laptopanddevbox, andcreatefails if the account has none.