datasets: implement a fallback URL mechanism. - #75
Open
ilia-kats wants to merge 7 commits into
Open
Conversation
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 92.63% 92.77% +0.13%
==========================================
Files 11 11
Lines 584 609 +25
==========================================
+ Hits 541 565 +24
- Misses 43 44 +1
🚀 New features to boost your workflow:
|
- get rid of the Sphinx warnings - more explicit docstrings
ilia-kats
force-pushed
the
datasets_improvements
branch
from
August 21, 2026 13:31
0cbb40c to
0078634
Compare
flying-sheep
requested changes
Aug 21, 2026
Comment on lines
+117
to
+118
| for fallback in file.fallback_urls: | ||
| return download(replace(file, url=fallback, fallback_urls=None), dest=dest, processor=processor) |
Member
There was a problem hiding this comment.
That doesn’t make sense to me, either the return or an exception will end this loop immediately.
I think having one fallback_url per file is enough anyway, the only reason SnapATAC2 had a dict is because it needed to be specified in metadata
Collaborator
Author
There was a problem hiding this comment.
Just realized this as well a moment ago.
Collaborator
Author
There was a problem hiding this comment.
should be fixed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is apparently being used in the wild with workarounds, so we should provide it here.