Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache.Clientimplementation that reads last-applied config via a newconfig_read.ConfigReadServicegRPC client instead of the local/dragonfly cache.Pairs-with: sdcio/config-server#476
Pairs-with: sdcio/integration-tests#115
Note on integration coverage
The
integration-testsjob now runstests/05-cache-backend/(CRUD round-trip + restart-recovery) against aCache.Type: config-serverdeployment viasdcio/integration-testsPR #115, which extendssingle.ymlwithcache_type/suites_to_runinputs and adds the suite itself.Pairs-with: sdcio/integration-tests#115supersedes the previous#113reference: #115's branch bundles #113'sconfig-keyringSecret fix directly (a hard, cache-backend-independent prerequisite -- without itdata-server-controllerhangs inContainerCreatingfor any deploy) alongside the actual cache-backend suite/workflow changes, so a single paired ref now covers both concerns.