Repository navigation
Conversation
Wire subscribe-ONCE through the same Running apply path as GetSync, latch Synced only after SyncResponse and successful apply, and skip interval ticks while a cycle is in flight.
gotSyncResponse is only read when the subscribe stream closes; assigning it before return was unused.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
once: subscribe-ONCE cycles update Running via the same scoped-refresh path as GetSync (applyScopedRefreshFromCycleTree).MarkSyncedonly after a successful apply onSyncResponse; subscribe failures or streams that end withoutSyncResponsedo not commit.cycleRunning) so interval ticks skip while a cycle is in flight; parse sync paths and wireschemaClientat construction (invalid paths fail inAddSyncs).CONTEXT.mdSynced glossary to include OnceSync (Phase B of running-sync-empty-and-once).Stacks on #501 (
synced-gate). Parent spec:.scratch/open/09-running-sync-empty-and-once-spec.md.Test plan
go test ./pkg/datastore/target/gnmi/ -run OnceSyncgo test ./...mode: oncesync against a target that returns ONCE + SyncResponse