Skip to content

feat: make success comments filterable#360

Closed
balazsorban44 wants to merge 1 commit into
semantic-release:masterfrom
balazsorban44:patch-1
Closed

feat: make success comments filterable#360
balazsorban44 wants to merge 1 commit into
semantic-release:masterfrom
balazsorban44:patch-1

Conversation

@balazsorban44

@balazsorban44 balazsorban44 commented Apr 23, 2021

Copy link
Copy Markdown

Fixes #359

@jpsullivan

jpsullivan commented May 24, 2021

Copy link
Copy Markdown

I know this isn't particularly helpful, but my team has been running into this as well, and would love to see this merged in. If there's anything I can do to assist, please feel free to let me know!

@oljp oljp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However I do think that documentation should be included for this filter as well.

@balazsorban44

balazsorban44 commented May 25, 2021

Copy link
Copy Markdown
Author

Of course! I can do, that, if you point me to the right place. 😊

@oljp

oljp commented May 25, 2021

Copy link
Copy Markdown

I'm not an official maintainer, though if I were to assume I'd go ahead and drop the successFilter into the Options category of the README. https://github.com/semantic-release/github/blob/master/README.md#options, providing a brief description and maybe some example values.

@gr2m

gr2m commented May 25, 2021

Copy link
Copy Markdown
Member

sorry for the delay with reviewing PRs. We are all pretty swamped right now, but how to find time to review the open PRs and onboard new maintainers soon

@raffis

raffis commented Nov 4, 2022

Copy link
Copy Markdown

Any reason this is not merged? Currently I have the problem that if semantic-release with github gets added to an old repo with thousands of merged pr's, you end up with thousands of comments done by semantic-release. I wonder why this was not yet mentioned anywhere.
A filter would help in this case, we could add the released label manually to all merged pr's before introducing semantic-release.
Alternative solution might also the ability to specify a custom github search query.

@babblebey

babblebey commented Jul 8, 2024

Copy link
Copy Markdown
Member

So we've got a similar feature merged on the semantic-release/gitlab plugin, and more robust at that. It'd be nice if we can replicate the exact same flow here which i believe should succeed this PR. 😉

See semantic-release/gitlab#730

@github-actions

github-actions Bot commented Sep 2, 2024

Copy link
Copy Markdown

🎉 This issue has been resolved in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter PR/Issue that should get a comment on success

6 participants