Skip to content

wip(agent): fatal tool-arg schema validation -> model-visible error (tinyhumansai#4451) - #4

Closed
senamakel wants to merge 1 commit into
agent/vendor-tinyagentsfrom
agent/fix-4451
Closed

senamakel wants to merge 1 commit into
agent/vendor-tinyagentsfrom
agent/fix-4451

Conversation

@senamakel

Copy link
Copy Markdown
Owner

⚠️ Partial / needs verification. Implementation salvaged from the parity workflow after the subagent was killed by the monthly spend limit before it could run cargo check, fix any compile errors, and open the PR. Preserved so the work isn't lost.

Addresses tinyhumansai#4451 (see that issue for problem/fix plan/acceptance criteria).

  • Includes a vendor/tinyagents crate change (ValidationPolicy) on branch agent/fix-4451 of senamakel/tinyagents (submodule pointer bumped here).

TODO before merge: cargo check --lib + targeted tests, resolve any compile errors, confirm acceptance criteria. Do not merge until green.

https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR

…model-visible error

Salvaged from the parity workflow worktree after the subagent hit the monthly
spend limit before verifying/opening a PR. Seam changes (middleware.rs, mod.rs)
+ e2e test scaffold in tests/agent_harness_e2e.rs, plus a vendored tinyagents
ValidationPolicy addition (submodule bump). NOT build-verified. Preserved so
the work is not lost.

Ref: tinyhumansai#4451
Claude-Session: https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR
@cursor

cursor Bot commented Jul 3, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@senamakel

Copy link
Copy Markdown
Owner Author

Superseded — re-implementing fresh on the post-merge base (upstream tinyhumansai#4473 landed, changing the seam). A new build-verified PR will replace this.

@senamakel senamakel closed this Jul 3, 2026
@senamakel
senamakel deleted the agent/fix-4451 branch July 3, 2026 23:04
senamakel pushed a commit that referenced this pull request Oct 16, 2026
- #6: the service trusts every files folder (`tiny_store::file_roots`), so
  an artifact made in an earlier one can still be revised.
- #8: a failed revision keeps the artifact: the record keeps its versions
  and the card shows the newest of them again.
- #9: a failure the observer could not show fails the card directly, and a
  completion that records nothing fails the record too; no card stays
  "generating".
- #10: listing a thread's artifacts (the row backfill, the UI) queries the
  `by_thread` index instead of reading the whole workspace.
- #4: the open preview re-reads the artifact when a new version is saved
  (an agent revision) unless an edit is pending; the panel is keyed per
  artifact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
senamakel pushed a commit that referenced this pull request Oct 16, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant