Skip to content

Sendgrid is using cryptographically unsafe ecdsa-dotnet #1087

Closed

Description

@shoter

Issue Summary

Currently ecdsa-dotnet has an issue where it is using Random in order to verify some signatures. It is troublesome for static analyzers like Veracode because they treat this as a vulnerability.
I currently submitted PR that should fix that issue in the upcoming version of ecdsa-dotnet.

Technical details:

  • sendgrid-csharp version: Up from [2020-06-24] Version 9.17.0 which adds Elliptic curve code (the same code as in ecdsa-dotnet)
  • csharp version: Any

Activity

  1. JenniferMah commented on Feb 2, 2021

    @JenniferMah
    Contributor

    Hi @shoter
    Thanks for bringing this to our attention. Is your suggestion to also use RandomNumberGenerator.GetBytes Method instead of random here?

  2. shoter commented on Feb 2, 2021

    @shoter
    ContributorAuthor

    I believe this Integer.cs was deleted from the code in favor of using ecdsa-dotnet.

    But if you would like to bring it back then it would bring the same issue unless You use RandomNumberGenerator.GetBytes Method

    For example for our project we need to work on version before Integer.cs was introduced because of this issue.

  3. eshanholtz commented on Feb 4, 2021

    @eshanholtz
    Contributor

    @shoter So what it sounds like is we'll just have to bump our dependency version when a new version of ecdsa-dotnet is released with a fix. Until then, you're welcome to submit a PR here to bring back the local Elliptic Curve code solution, with the fix you're suggesting, so you can continue to use this helper library until your PR in ecdsa-dotnet is merged and released.

  4. BeigeBox commented on Apr 6, 2021

    @BeigeBox

    The ecdsa-dotnet project just updated to 1.3.1 (15 minutes ago), so we should be good to bump the dependency soon as they make a full release (latest release is still tagged as 1.3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions