Repository navigation
chore: migrate to GitHub Actions - #1142
Merged
Merged
Conversation
eshanholtz
force-pushed
the
gh-actions
branch
from
November 18, 2021 19:20
d382b66 to
fb3b680
Compare
eshanholtz
marked this pull request as ready for review
November 18, 2021 19:23
eshanholtz
marked this pull request as draft
November 18, 2021 19:28
eshanholtz
marked this pull request as ready for review
November 18, 2021 19:53
eshanholtz
marked this pull request as draft
November 18, 2021 21:19
This reverts commit 9551e3c.
eshanholtz
marked this pull request as ready for review
November 18, 2021 23:53
JenniferMah
reviewed
Nov 19, 2021
JenniferMah
previously approved these changes
Nov 19, 2021
eshanholtz
force-pushed
the
gh-actions
branch
from
November 19, 2021 23:46
6c02f40 to
3e6acc2
Compare
Contributor
|
Travis should probably be removed from this test file. |
Contributor
Author
|
If that test is there, then how is the test passing?? I should have seen that test failure |
JenniferMah
dismissed
their stale review
November 21, 2021 17:23
Re-review after all tests are running.
shwetha-manvinkurke
approved these changes
Nov 22, 2021
shwetha-manvinkurke
left a comment
Contributor
There was a problem hiding this comment.
Also need to remove .travis.yml from the solution
Contributor
Author
|
@JenniferMah created DI-1844 to address running tests for sendgrid csharp libs. Out of scope for this ticket. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.