Skip to content

chore: migrate to GitHub Actions - #1142

Merged
eshanholtz merged 18 commits into
mainfrom
gh-actions
Nov 22, 2021
Merged

eshanholtz merged 18 commits into
mainfrom
gh-actions

Conversation

@eshanholtz

Copy link
Copy Markdown
Contributor

No description provided.

@eshanholtz
eshanholtz marked this pull request as ready for review November 18, 2021 19:23
@eshanholtz
eshanholtz marked this pull request as draft November 18, 2021 19:28
@eshanholtz
eshanholtz marked this pull request as ready for review November 18, 2021 19:53
Comment thread .github/workflows/deploy.yml Resolved
Comment thread .github/workflows/test.yml Resolved
Comment thread .github/workflows/test.yml Resolved
Comment thread Makefile Resolved
Comment thread .travis.yml Resolved
@eshanholtz
eshanholtz marked this pull request as draft November 18, 2021 21:19
This reverts commit 9551e3c.
@eshanholtz
eshanholtz marked this pull request as ready for review November 18, 2021 23:53
Comment thread .github/workflows/test.yml Resolved
Comment thread .github/workflows/test.yml Resolved
Comment thread .github/workflows/deploy.yml Resolved
JenniferMah
JenniferMah previously approved these changes Nov 19, 2021
@JenniferMah

Copy link
Copy Markdown
Contributor

Travis should probably be removed from this test file.

@eshanholtz

Copy link
Copy Markdown
Contributor Author

If that test is there, then how is the test passing?? I should have seen that test failure

@JenniferMah
JenniferMah dismissed their stale review November 21, 2021 17:23

Re-review after all tests are running.

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to remove .travis.yml from the solution

@eshanholtz

Copy link
Copy Markdown
Contributor Author

@JenniferMah created DI-1844 to address running tests for sendgrid csharp libs. Out of scope for this ticket.

@eshanholtz
eshanholtz merged commit 6169c51 into main Nov 22, 2021
@eshanholtz
eshanholtz deleted the gh-actions branch November 22, 2021 19:08
@akunzai akunzai mentioned this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants