Repository navigation
fix(core, analyzer): Fix method boundary instructions - #407
Merged
Merged
Conversation
JIRLambdaMethod, OpentaintLambdaProxyMethod and SpringGeneratedMethod override instList with a directly built list and never pass through the JIRInstExtFeature pipeline, so they had no JMethodEnterInst / JMethodExitNormalInst / JMethodExitExceptionalInst. Their instList now applies JMethodBoundaryInstFeature.transformInstList lazily, and the JVM analysis fails fast when a non-empty method reaches it without boundary instructions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Method-exit source and sink rules now run on JMethodExitNormalInst / JMethodExitExceptionalInst (method result Return / Exception); return and throw are plain transfers to Return / Exception. Facts unchanged by the exit rules keep the condition-reader refinement. Consumers follow: - the sequent precondition applies exit sources on the boundaries and answers the queried fact with Unchanged plus exit-source preconditions; - the forward trace resolver records the method-end successor for a trace starting on an exit boundary (VulnerabilityChecker final node); - SARIF resolves an exit boundary location like a generated location: the last return/throw of the first relevant flow, else the method's last one; - isTraceRequiredInstruction also keeps JMethodExitNormalInst. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The sequent flow function and precondition list JMethodExitNormalInst and JMethodExitExceptionalInst as explicit when branches instead of routing them through an else clause, and the precondition dispatch is a single when. The methodExitBase helper is no longer needed and is removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Exit boundary instructions have no local operands, so possible aliases at them are always empty. Exit sources are evaluated only by the exit precondition, which makes the applyExitSourceRules flag constant and it is removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.