🐞 Voting Portal: Prevent advancing from required contests with no selection - #3089
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Findeton
added a commit
that referenced
this pull request
Aug 24, 2026
…ection (#3089) Parent issue: sequentech/meta#12975
Findeton
added a commit
that referenced
this pull request
Aug 25, 2026
…ection (#3089) (#3091) Parent issue: sequentech/meta#12975
ruescasd
added a commit
that referenced
this pull request
Sep 1, 2026
Catch-up merge (14 commits). Three conflicts, all at the seam between upstream's changes and this branch's rationalized-validation injection: - sequent-core/util/voting_screen.rs: upstream edited the pre-injection gate bodies (which this branch replaced). Both upstream behaviours are composition-layer and re-expressed on the injected composition: the gates iterate votable_contests(...) — acclaimed contests are skipped (#3106) — and the hard gate FAILS CLOSED on a contest missing from the decoded map (#3089); the dialog keeps false there, as upstream does. The per-contest predicate (the certified domain) is untouched. Upstream's copy of Defect 2's console_log died with its old body. - voting-portal InvalidErrorsList.tsx: upstream's WCAG pass added aria-describedby ids and live-region roles (kept, render-side) and cosmetically tidied the old filterErrorList (superseded — this branch's rewritten filter stands; the S1 mute remains a deliberate, attributable diff against upstream). - velvet do_tally/tally.rs: upstream added an Acclaimed counting algorithm and a factory test into the tests module this branch moved to velvet-core. Resolution keeps the extraction (the moved Tally/process_tally_sheet tests stay in velvet-core) and ports only the new factory test; acclaimed.rs is adapted to this branch's CountingAlgorithm trait (the injectable tie-breaking rng — unused by the synthetic result). Native suites: sequent-core 190/190 (upstream's acclaimed tests included), validation-adapters 6/6, validation-spec 14/14, velvet 41 passed with only the nine pre-existing PDF-environment failures (same set as the pre-merge baseline); both gate tests and the acclaimed factory test green. Apparatus re-run against the merged production follows separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12975