Avatar reupload config update - #971
Merged
Merged
Conversation
…to keep the file server image alive
AL-Session
approved these changes
Feb 24, 2025
AL-Session
left a comment
AL-Session
left a comment
Contributor
There was a problem hiding this comment.
Nice.
You could change the first line of DownloadUtilities.downloadFile to:
destination.outputStream().use { outputStream ->
which would then properly close the output stream even if there's an exception thrown during the download.
SessionHero01
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making sure we update the user config when reuploading the avatar (the reupload mechanism is a way of keeping the avatar alive on the file server).
Also changed the failing logic for avatars and attachments to avoid constantly retrying downloads on 404 responses.