Group poller tweaks - #995
Merged
Merged
Conversation
| } | ||
|
|
||
| // Take a random snode from the pool | ||
| val snode = pollState.pollPool.random().also { |
Collaborator
There was a problem hiding this comment.
Do you need this val snode if the content is already set on currentSnode ?
Collaborator
Author
There was a problem hiding this comment.
It's just nice that I don't have to do currentSnode!! everywhere
| Log.e(TAG, "Group polling failed due to a server error", badResponse) | ||
| } | ||
|
|
||
| pollState.swarmNodes -= currentSnode!! |
Collaborator
There was a problem hiding this comment.
So you're removing the currentSnode no matter what on error? You are not using badResponse at all?
Collaborator
Author
There was a problem hiding this comment.
Good spotting lol
ThomasSession
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically this: