Skip to content

Simplify test_chunked_prefill; remove redundant tests - #22652

Merged
hnyls2002 merged 8 commits into
mainfrom
lsyin/simplify-chunked-prefill
Apr 13, 2026
Merged

hnyls2002 merged 8 commits into
mainfrom
lsyin/simplify-chunked-prefill

Conversation

@hnyls2002

Copy link
Copy Markdown
Collaborator

Summary

Remove redundant tests in test_chunked_prefill.py to reduce CI time:

  • test_chunked_prefill — default path (radix_cache=True, mixed_chunk=False), implicitly covered by all other MMLU integration tests
  • test_chunked_prefill_without_radix_cache — disable_radix_cache path is already covered by test_no_overlap_scheduler.py
  • test_mixed_chunked_prefill_multi_requests — no accuracy assertion (just response.json()); chunked_prefill_size=2048 rarely triggers chunking on short prompts

Keep:

  • test_mixed_chunked_prefill — unique coverage of enable_mixed_chunk=True on default path
  • test_mixed_chunked_prefill_without_radix_cache — unique coverage of mixed_chunk + disable_radix_cache combo

Test plan

  • CI: test_chunked_prefill.py passes with remaining 2 tests
  • May need to adjust est_time (currently 360) after CI run

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the chunked prefill test suite by removing several test cases, including those for multi-request scenarios. Feedback indicates that the remaining tests should explicitly define "chunked_prefill_size" to ensure the chunked prefill logic is properly exercised. Furthermore, it is recommended to restore and adjust the multi-request test case rather than removing it, as it provides critical coverage for concurrent request scheduling.

I am having trouble creating individual review comments. Click here to see my feedback.

test/registered/scheduler/test_chunked_prefill.py (16)

medium

The test test_mixed_chunked_prefill does not explicitly set chunked_prefill_size. In the scheduler implementation, is_mixed_chunk is only enabled if chunked_prefill_size is not None. Without this parameter, the test may not be exercising the chunked prefill logic. Consider explicitly passing a chunked_prefill_size (e.g., 128) to ensure the intended code path is tested.

        run_mmlu_test(disable_radix_cache=False, enable_mixed_chunk=True, chunked_prefill_size=128)

test/registered/scheduler/test_chunked_prefill.py (19)

medium

Similar to the test above, chunked_prefill_size should be explicitly set here to ensure that chunked prefill is actually active during the test.

        run_mmlu_test(disable_radix_cache=True, enable_mixed_chunk=True, chunked_prefill_size=128)

test/registered/scheduler/test_chunked_prefill.py (27-31)

medium

Removing test_mixed_chunked_prefill_multi_requests eliminates coverage for concurrent requests with chunked prefill. While the current implementation might not trigger chunking frequently with a size of 2048 on short prompts, it is better to fix the test by reducing the chunked_prefill_size (e.g., to 128) rather than removing it. This provides valuable coverage for the scheduler's state management under load, which sequential MMLU tests may miss.

@hnyls2002

Copy link
Copy Markdown
Collaborator Author

/rerun-test test_mixed_chunked_prefill.py

@hnyls2002
hnyls2002 marked this pull request as ready for review April 13, 2026 03:18
@github-actions

Copy link
Copy Markdown
Contributor

✅ 1-gpu-5090 (1 test): View workflow run

cd test/ && python3 registered/scheduler/test_mixed_chunked_prefill.py

@hnyls2002

Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@github-actions github-actions Bot added the run-ci CI: run the baseline test suite on this PR label Apr 13, 2026
@hnyls2002
hnyls2002 merged commit c775c31 into main Apr 13, 2026
33 of 39 checks passed
@hnyls2002
hnyls2002 deleted the lsyin/simplify-chunked-prefill branch April 13, 2026 03:26
caitengwei pushed a commit to caitengwei/sglang that referenced this pull request Jun 1, 2026
Chronostasys pushed a commit to MindLab-Research/sglang that referenced this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci CI: run the baseline test suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant