Skip to content

[Docs] Fix default values and options in Ascend server arguments documentation - #22698

Merged
sglang-npu-bot merged 1 commit into
sgl-project:mainfrom
xdtbynd:doc_mod
Apr 13, 2026
Merged

sglang-npu-bot merged 1 commit into
sgl-project:mainfrom
xdtbynd:doc_mod

Conversation

@xdtbynd

@xdtbynd xdtbynd commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

This pull request updates the documentation for server arguments to accurately reflect the current defaults, available options, and support status for various features in the Ascend backend (A2, A3). Several descriptions were outdated or contained placeholder information. This change ensures users have correct configuration guidance and are aware of features still in planning.

Key issues addressed:

  • Correcting the default value for --speculative-draft-load-format.
  • Updating the --tool-call-parser options to match the currently implemented parsers for Ascend.
  • Clarifying the planned but unsupported status of --disaggregation-decode-enable-offload-kvcache.
  • Removing duplicate table entries in the HTTP server section.

Modifications

The following sections in the server arguments documentation have been updated:

  1. HTTP Server:

    • Removed a duplicate table block.
    • Standardized the --grpc-mode server supported description to explicitly state Planned.
  2. API related:

    • --tool-call-parser: Updated the list of valid options to llama3, pythonic, qwen, and qwen3_coder to reflect the currently supported parsers on the Ascend backend.
    • Minor formatting adjustments to the --reasoning-parser options.
  3. Speculative decoding:

    • --speculative-draft-load-format: Changed the default value from None to auto.
    • --speculative-draft-model-revision: Expanded the "Options" description to include specific examples (branch name, tag name, commit id).
  4. Disaggregation:

    • --disaggregation-decode-enable-offload-kvcache: Updated the server supported column to server supported description to explicitly state Planned to accurately indicate the current lack of support for KV cache offloading on Ascend.

Accuracy Tests

N/A - This PR only updates documentation and does not modify any model forward code or kernel logic.

Speed Tests and Profiling

N/A - This PR only updates documentation and does not impact inference speed.

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@github-actions github-actions Bot added documentation Improvements or additions to documentation npu labels Apr 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for Ascend NPU support features by refining the available options and default values for several server arguments, including --grpc-mode, --tool-call-parser, and speculative decoding settings. A typo was identified in the description for the --disaggregation-decode-enable-offload-kvcache argument.

Comment thread docs/platforms/ascend/ascend_npu_support_features.md Outdated
@xdtbynd xdtbynd changed the title modify supported features [Docs] Fix default values and options in Ascend server arguments documentation Apr 13, 2026
@sglang-npu-bot
sglang-npu-bot merged commit d01b2bf into sgl-project:main Apr 13, 2026
41 checks passed
caitengwei pushed a commit to caitengwei/sglang that referenced this pull request Jun 1, 2026
…mentation (sgl-project#22698)

Co-authored-by: xdtbynd <supercluster@vip.qq.com>
Chronostasys pushed a commit to MindLab-Research/sglang that referenced this pull request Aug 24, 2026
…mentation (sgl-project#22698)

Co-authored-by: xdtbynd <supercluster@vip.qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation npu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants