Skip to content

[NPU] --attn-cp-size --init-expert-location --eplb-algorithm parameter docs update - #22704

Merged
sglang-npu-bot merged 6 commits into
sgl-project:mainfrom
Hide-on-bushsh:docs
Apr 13, 2026
Merged

sglang-npu-bot merged 6 commits into
sgl-project:mainfrom
Hide-on-bushsh:docs

Conversation

@Hide-on-bushsh

@Hide-on-bushsh Hide-on-bushsh commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

image

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@github-actions github-actions Bot added documentation Improvements or additions to documentation npu labels Apr 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Ascend NPU support features documentation by adding specific constraints and valid values for the --attn-cp-size, --init-expert-location, and --eplb-algorithm arguments. The review feedback focuses on improving documentation clarity and consistency, specifically recommending the use of semicolons for constraints and the removal of angle brackets from literal values to avoid confusion with placeholders.

Comment thread docs/platforms/ascend/ascend_npu_support_features.md Outdated
Comment thread docs/platforms/ascend/ascend_npu_support_features.md Outdated
Hide-on-bushsh and others added 2 commits April 13, 2026 22:06
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sglang-npu-bot sglang-npu-bot changed the title docs update [NPU] docs update Apr 13, 2026
@Hide-on-bushsh Hide-on-bushsh changed the title [NPU] docs update [NPU] --attn-cp-size --init-expert-location --eplb-algorithm parameter docs update Apr 13, 2026
@sglang-npu-bot
sglang-npu-bot merged commit b6a91b1 into sgl-project:main Apr 13, 2026
41 checks passed
caitengwei pushed a commit to caitengwei/sglang that referenced this pull request Jun 1, 2026
…r docs update (sgl-project#22704)

Co-authored-by: Jianzhao Xu <xujianchao@huawei.com>
Chronostasys pushed a commit to MindLab-Research/sglang that referenced this pull request Aug 24, 2026
…r docs update (sgl-project#22704)

Co-authored-by: Jianzhao Xu <xujianchao@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation npu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants