Skip to content

Single comment with quote - #154

Merged
shellscape merged 2 commits into
shellscape:masterfrom
life777:single-comment-with-quote
Feb 22, 2021
Merged

Single comment with quote#154
shellscape merged 2 commits into
shellscape:masterfrom
life777:single-comment-with-quote

Conversation

@life777

@life777 life777 commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

**Which issue #145 if any, does this resolve?

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

This fix is simple. Before when code finds a quote symbol in comment it overwrites an this.input and this.tokenizer before new token for the comment is created. It means when code tries to get a position by offset getPosition it searches for in in new input, but should in old one.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #154 (ebd3129) into master (d19dff9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files           3        3           
  Lines         153      153           
=======================================
  Hits          149      149           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19dff9...ebd3129. Read the comment docs.

@shellscape

Copy link
Copy Markdown
Owner

Thanks for opening a PR for this 🍺 I'll have a look early tomorrow.

@life777

life777 commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

@shellscape
Are there any problems with my fix that I should change?

@shellscape
shellscape merged commit 0cacd37 into shellscape:master Feb 22, 2021
@shellscape

Copy link
Copy Markdown
Owner

thanks!

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (d19dff9) to head (ebd3129).
⚠️ Report is 13 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files           3        3           
  Lines         153      153           
=======================================
  Hits          149      149           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants