Skip to content

SG-45337 Make Codecov checks advisory - #89

Open
julien-lang wants to merge 1 commit into
masterfrom
ticket/SG-45337-codecov-advisory
Open

julien-lang wants to merge 1 commit into
masterfrom
ticket/SG-45337-codecov-advisory

Conversation

@julien-lang

@julien-lang julien-lang commented Sep 18, 2026

Copy link
Copy Markdown
Member

tk-toolchain's codecov.yml only configured the project status, leaving patch on Codecov's default, so codecov/patch failed and blocked PRs whenever the changed lines were not exercised by unit tests (e.g. setup.py, conf.py, mechanical refactors). This mirrors the tk-core SG-43838 pattern to make the Codecov checks advisory.

Changes

  • Make both the project and patch Codecov statuses informational: true (report, never block CI).
  • Set an 80% target on both, plus a 1% project threshold to ignore small-change noise.
  • Keep the existing only_pulls: true on the project status.

Reference

Testing

  • Config-only change; Codecov continues to report coverage but no longer fails the check.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Updates Codecov configuration so coverage checks report results without blocking pull requests.

Changes:

  • Makes project and patch statuses informational.
  • Sets 80% coverage targets and a 1% project threshold.
  • Preserves only_pulls: true.
File summaries
File Description
codecov.yml Configures advisory project and patch coverage checks.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.13%. Comparing base (b3e4374) to head (47ccbd8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files          18       18           
  Lines         639      639           
=======================================
  Hits          282      282           
  Misses        357      357           
Flag Coverage Δ
Linux 43.66% <ø> (ø)
Python-3.10 43.66% <ø> (ø)
Python-3.11 44.13% <ø> (ø)
Python-3.13 44.13% <ø> (ø)
Python-3.9 43.66% <ø> (ø)
Windows 43.64% <ø> (ø)
macOS 43.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julien-lang
julien-lang marked this pull request as ready for review September 18, 2026 20:41
@julien-lang julien-lang changed the title SG-45337 Make Codecov checks advisory (mirror SG-43838) SG-45337 Make Codecov checks advisory Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants