[Outlaw] Add 12.1 changes and set bonus#11546
Conversation
soloxcx
commented
Jun 29, 2026
soloxcx
commented
- Update Zero In proc behavior with daggers
- Add MID2 set bonus for Outlaw
- Update Zero In proc behavior with daggers - Add MID2 set bonus for Outlaw
| p()->resource_loss( RESOURCE_COMBO_POINT, max_spend ); | ||
| p()->resource_loss( RESOURCE_COMBO_POINT, cp_loss ); | ||
|
|
||
| p()->sim->print_log( "{} consumes {} {} for {} ({})", *p(), max_spend, util::resource_type_string( RESOURCE_COMBO_POINT ), |
There was a problem hiding this comment.
| p()->sim->print_log( "{} consumes {} {} for {} ({})", *p(), max_spend, util::resource_type_string( RESOURCE_COMBO_POINT ), | |
| p()->sim->print_log( "{} consumes {} {} for {} ({})", *p(), cp_loss, util::resource_type_string( RESOURCE_COMBO_POINT ), |
| set_bonuses.mid2_outlaw_2pc = sets->set( ROGUE_OUTLAW, MID2, B2 ); | ||
| set_bonuses.mid2_outlaw_4pc = sets->set( ROGUE_OUTLAW, MID2, B4 ); | ||
|
|
||
| spec.mid2_outlaw_4pc_buff = set_bonuses.mid2_outlaw_4pc->ok() ? set_bonuses.mid2_outlaw_4pc->effectN( 1 ).trigger() : spell_data_t::not_found(); |
There was a problem hiding this comment.
Don't need the ok() check here I don't believe. .trigger() on a spell data will return not_found if the spell data doesn't exist.
For simplification purposes, it may be worth putting the chance here though with
if( set_bonuses.mid2_outlaw_4pc->ok() )
{
spec.mid2_outlaw_4pc_buff->set_chance( set_bonuses.mid2_outlaw_4pc->effectN( 1 ).percent() );
}
This sets the trigger chance on the buff and will automatically rng roll when calling buff.trigger(). Then you wouldn't have to check the chance at runtime above. You can just call p()->buffs.mid2_outlaw_4pc->trigger();
Could then just remove the entire trigger_mid2_outlaw_4pc function since you'd just need a buff trigger call in two places without any other logic.
| buffs.mid1_outlaw_4pc = make_buff<damage_buff_t>( this, "whirl_of_blades", set_bonuses.mid1_outlaw_4pc->effectN(2).trigger() ); | ||
| buffs.mid1_outlaw_4pc = make_buff<damage_buff_t>( this, "whirl_of_blades", set_bonuses.mid1_outlaw_4pc->effectN( 2 ).trigger() ); | ||
|
|
||
| buffs.mid2_outlaw_4pc = make_buff( this, "fang_strike", spec.mid2_outlaw_4pc_buff ) |
There was a problem hiding this comment.
You may want to use make_buff_fallback here since it looks like you want to use this in the APL. Either the APL needs to have a prior set_bonus&& check to keep the buff.fang_strike conditional from evaluating or buff needs to be created as fallback so it exists even if the spell data doesn't.
2 participants
