Add .isWeakRef() - #164
Closed
iambinlin wants to merge 7 commits into
Closed
Add .isWeakRef()#164iambinlin wants to merge 7 commits into
.isWeakRef()#164iambinlin wants to merge 7 commits into
Conversation
Contributor
Author
|
All tests can passed in my local env.I don't know why ci doesn't pass. @sindresorhus |
Contributor
Author
|
Sorry, I may have used |
Owner
|
You should always make a separate branch for each pull request. |
Contributor
Author
Ok, when I get home later and reopen a branch, I just arrived at the company now, ready to work. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes as follow, Support #143 :
Support ts complier for WeakRef: updatetypescripttov 4.6.2(latest)Support test mock with JSDOM: updatejsdomtov 19.0.0(latest)Fix lint error: test code perf #163Add complierOptions for tsconfig.xo.json: fix follow error, However, the ide still reports an error. I don't quite clear which tsconfig the test file is ultimately controlled by. It seems that the addition is invalid.