Repository navigation
Multi arch docker images - #61
willianpaixao wants to merge 2 commits into
Conversation
|
|
||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
We want to still build this image during PRs, but only push when its been merged into master. That way we know for sure it'll successfully push once merged
There was a problem hiding this comment.
@HenryNguyen5 due to limitations Github Actions syntax, I decided to split into two workflows, one that only builds PRs and other that builds and publishes branches and tags.
| smartcontract/builder:1.1.0 | ||
| ${{ secrets.AWS_ECR_ACCOUNT_URL }}/builder:1.1.0 |
There was a problem hiding this comment.
We should encode the tag version as a variable
| smartcontract/builder:1.1.0 | ||
| ${{ secrets.AWS_ECR_ACCOUNT_URL }}/builder:1.1.0 | ||
| platforms: linux/386,linux/amd64,linux/arm64 | ||
| push: true |
There was a problem hiding this comment.
I would make this a conditional where it's only true when the branch is master, and false when its not. That way we can change the workflow triggers to satisfy #61 (comment)
There was a problem hiding this comment.
Hum, since this repo only publishes tags (not every commit to master) I decided to make the pipeline only publish upon branch and tags.
|
@HenryNguyen5 ping |
|
Thanks for getting back to us @willianpaixao! We'll go over this when we have the capacity to |
|
Hi @HenryNguyen5 any updates? |
|
@HenryNguyen5 ping |
|
We're still on CircleCI for publishing images, will come around to this when we use GHA for publishing! |
|
@HenryNguyen5 ok - thanks for letting know! |
|
@HenryNguyen5 any updates here? |
Related smartcontractkit/chainlink/pull/3614.