Skip to content

Add SVC::decision_function (#134)#135

Merged
morenol merged 1 commit into
smartcorelib:developmentfrom
ferrouille:add-decision-function
Jun 21, 2022
Merged

Add SVC::decision_function (#134)#135
morenol merged 1 commit into
smartcorelib:developmentfrom
ferrouille:add-decision-function

Conversation

@ferrouille

Copy link
Copy Markdown
Contributor

As discussed in #134, I have tried to implement decision_function for SVC.

Please let me know if you have any feedback.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #135 (d161595) into development (ff456df) will increase coverage by 0.01%.
The diff coverage is 95.45%.

@@               Coverage Diff               @@
##           development     #135      +/-   ##
===============================================
+ Coverage        83.41%   83.43%   +0.01%     
===============================================
  Files               78       78              
  Lines             8362     8377      +15     
===============================================
+ Hits              6975     6989      +14     
- Misses            1387     1388       +1     
Impacted Files Coverage Δ
src/svm/svc.rs 89.45% <95.45%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff456df...d161595. Read the comment docs.

@ferrouille
ferrouille force-pushed the add-decision-function branch from d161595 to ba54f74 Compare May 12, 2022 18:35
@ferrouille

Copy link
Copy Markdown
Contributor Author

My bad, I messed up the formatting. Should be fixed now.

@VolodymyrOrlov VolodymyrOrlov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @ferrouille!

@morenol
morenol merged commit b4a807e into smartcorelib:development Jun 21, 2022
morenol pushed a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants