Skip to content

Added additional doctest and fixed indices#141

Merged
morenol merged 3 commits into
smartcorelib:developmentfrom
cmccomb:development
Aug 12, 2022
Merged

Added additional doctest and fixed indices#141
morenol merged 3 commits into
smartcorelib:developmentfrom
cmccomb:development

Conversation

@cmccomb

@cmccomb cmccomb commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

Added an additional doctest to evd.rs for a matrix that resulted in failure before these changes. In several locations, changed indices from i as usize + 1 to (i+1) as usize to avoid overflow in type conversion.

Fixes #140.

@codecov-commenter

codecov-commenter commented Aug 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #141 (88713b4) into development (b482acd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #141      +/-   ##
===============================================
+ Coverage        83.40%   83.44%   +0.03%     
===============================================
  Files               78       78              
  Lines             8377     8377              
===============================================
+ Hits              6987     6990       +3     
+ Misses            1390     1387       -3     
Impacted Files Coverage Δ
src/algorithm/neighbour/bbd_tree.rs 88.00% <100.00%> (ø)
src/linalg/evd.rs 86.06% <100.00%> (ø)
src/svm/svr.rs 87.27% <100.00%> (ø)
src/tree/decision_tree_classifier.rs 82.60% <100.00%> (ø)
src/tree/decision_tree_regressor.rs 84.54% <100.00%> (ø)
src/optimization/first_order/lbfgs.rs 94.44% <0.00%> (+1.58%) ⬆️
src/optimization/line_search.rs 92.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cmccomb

cmccomb commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

@morenol I feel like I'm playing whackamole and I'm a little confused. Do you see what I'm doing wrong here?

@morenol

morenol commented Aug 12, 2022

Copy link
Copy Markdown
Collaborator

@morenol I feel like I'm playing whackamole and I'm a little confused. Do you see what I'm doing wrong here?

@cmccomb - I re-run the CI and it worked, it looks like there is a flaky test but not from your changes. I need to investigate that a little bit more

@morenol
morenol merged commit d905ebe into smartcorelib:development Aug 12, 2022
@cmccomb

cmccomb commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @morenol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in eigen decomposition?

3 participants