Added additional doctest and fixed indices#141
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #141 +/- ##
===============================================
+ Coverage 83.40% 83.44% +0.03%
===============================================
Files 78 78
Lines 8377 8377
===============================================
+ Hits 6987 6990 +3
+ Misses 1390 1387 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
@morenol I feel like I'm playing whackamole and I'm a little confused. Do you see what I'm doing wrong here? |
Collaborator
morenol
approved these changes
Aug 12, 2022
Contributor
Author
|
Thanks @morenol |
morenol
pushed a commit
that referenced
this pull request
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an additional doctest to
evd.rsfor a matrix that resulted in failure before these changes. In several locations, changed indices fromi as usize + 1to(i+1) as usizeto avoid overflow in type conversion.Fixes #140.