Handle multiclass precision/recall#152
Merged
Merged
Conversation
Collaborator
|
thanks for your contribution! This looks great, we would like to have your opinion about some major changes on how the lib manages arrays, available at PR#108 |
Mec-iS
approved these changes
Sep 13, 2022
Contributor
Author
Overall, the goals for #108 looks great! For context on my opinions, I'm working on https://postgresml.org/. We're currently implemented as a Python wrapper, but undertaking an effort to port everything to Rust, which is possible in no small part due to smartcore. Raw performance (not copying data) is the primary reason.
|
morenol
pushed a commit
that referenced
this pull request
Nov 8, 2022
* handle multiclass precision/recall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
microaveraging for multiclass precision/recall to handle #151. I believe this is a good default, since it handles imbalanced labels better thanmacroaveraging (which is also not yet implemented).Additionally, the documentation for
to_f32_bitsis incorrect, and that function may currently cause unexpected behavior because it truncates half the bits for f64 values. This breaks things like the uniqueness check I'm doing to count the number of distinct labels. I'd also be open to better methods to count distinct floating point values in Rust, but I haven't seen an easy library function that handles this (with nans etc). I've addedto_f64_bitsto provide the behavior I expected.