Skip to content

fix: fix compilation warnings when running only with default features#160

Merged
morenol merged 2 commits into
smartcorelib:developmentfrom
morenol:lmm/fix-compilation-warnings
Sep 19, 2022
Merged

fix: fix compilation warnings when running only with default features#160
morenol merged 2 commits into
smartcorelib:developmentfrom
morenol:lmm/fix-compilation-warnings

Conversation

@morenol

@morenol morenol commented Sep 19, 2022

Copy link
Copy Markdown
Collaborator

I got:

warning: unused import: `itertools::Itertools`
 --> /Users/morenol/me/smartcore/src/algorithm/neighbour/fastpair.rs:2:5
  |
2 | use itertools::Itertools;
  |     ^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

which is only used in force-brute implementation

@morenol
morenol requested a review from Mec-iS September 19, 2022 14:30
@Mec-iS

Mec-iS commented Sep 19, 2022

Copy link
Copy Markdown
Collaborator

thanks for this.

@morenol
morenol merged commit 2510ca4 into smartcorelib:development Sep 19, 2022
@morenol
morenol deleted the lmm/fix-compilation-warnings branch September 19, 2022 14:44
morenol added a commit that referenced this pull request Nov 8, 2022
…#160)

* fix: fix compilation warnings when running only with default features
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants