Skip to content

Make rand_distr optional#161

Merged
Mec-iS merged 1 commit into
smartcorelib:developmentfrom
morenol:lmm/rand-distr-optional
Sep 20, 2022
Merged

Make rand_distr optional#161
Mec-iS merged 1 commit into
smartcorelib:developmentfrom
morenol:lmm/rand-distr-optional

Conversation

@morenol

@morenol morenol commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

rand_distr is only used in dataset module

use rand_distr::Normal;

@morenol
morenol requested a review from Mec-iS September 20, 2022 03:01
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #161 (4ed7ddc) into development (436da10) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #161      +/-   ##
===============================================
- Coverage        84.25%   84.18%   -0.07%     
===============================================
  Files               85       85              
  Lines             9196     9196              
===============================================
- Hits              7748     7742       -6     
- Misses            1448     1454       +6     
Impacted Files Coverage Δ
src/optimization/line_search.rs 82.00% <0.00%> (-8.00%) ⬇️
src/optimization/first_order/lbfgs.rs 92.85% <0.00%> (-1.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mec-iS
Mec-iS merged commit 6a2e104 into smartcorelib:development Sep 20, 2022
@morenol
morenol deleted the lmm/rand-distr-optional branch September 20, 2022 15:52
morenol added a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants