Port num.rs from #108#173
Merged
Merged
Conversation
montanalow
reviewed
Sep 26, 2022
montanalow
left a comment
montanalow
left a comment
Contributor
There was a problem hiding this comment.
I don't think I'm familiar enough with the usage of these primitives throughout SmartCore to effectively review and see issues that would arise.
Collaborator
Author
|
I created a new branch where to proceed with the merging of the new code with the new num-traits implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will add the "Authored" annotations at merge to assign the right credit to Volodymyr
Please provide a road map suggesting how to proceed next. Which modules are ready to be ported?