feat: Create GridSearchCV#180
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #180 +/- ##
===============================================
- Coverage 84.64% 84.56% -0.08%
===============================================
Files 86 86
Lines 9948 9974 +26
===============================================
+ Hits 8420 8435 +15
- Misses 1528 1539 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
montanalow
approved these changes
Oct 1, 2022
montanalow
left a comment
montanalow
left a comment
Contributor
There was a problem hiding this comment.
Consistency makes sense. Looks good to me.
morenol
added a commit
that referenced
this pull request
Nov 8, 2022
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little bit of refactoring of the search_grid module to add the GridSearchCV with a similar shape to https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.GridSearchCV.html#
@montanalow please let me know if this sounds good to you. I would love to have this merged before addressing #169