Skip to content

feat: better workarts in notifications - #1291

Merged
mdydek merged 4 commits into
mainfrom
feat/workart-improvements
Oct 13, 2026
Merged

mdydek merged 4 commits into
mainfrom
feat/workart-improvements

Conversation

@mdydek

@mdydek mdydek commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Closes #1264, #1280

⚠️ Breaking changes ⚠️

Introduced changes

  • comparison on 4000 x 4000 artwork using argent:
    • android: 128 MB on main vs 3.1 MB on this branch (caching also included)
    • ios 32.5 MB on main vs 4.2 MB on this branch (caching also included)

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek mdydek changed the title feat: better workart feat: better workarts in notifications Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

WPT non-regression comparison

PASS — no regressions · 0 improved section(s) · overall 3427 → 3427 (0)

Unchanged sections (28)
Spec section Base pass Head pass Delta
Processing model 1 1 0
Other 56 56 0
AnalyserNode 138 138 0
AudioBuffer 140 140 0
AudioBufferSourceNode 220 220 0
AudioContext 58 58 0
AudioNode 261 261 0
AudioParam 680 680 0
BiquadFilterNode 275 275 0
ChannelMergerNode 30 30 0
ChannelSplitterNode 7 7 0
ConstantSourceNode 64 64 0
ConvolverNode 178 178 0
DelayNode 127 127 0
DestinationNode 0 0 0
DynamicsCompressorNode 4 4 0
GainNode 15 15 0
IIRFilterNode 87 87 0
MediaElementAudioSourceNode 0 0 0
MediaStreamAudioDestinationNode 1 1 0
MediaStreamAudioSourceNode 0 0 0
OfflineAudioContext 35 35 0
OscillatorNode 104 104 0
PannerNode 727 727 0
PeriodicWave 33 33 0
ScriptProcessorNode 0 0 0
StereoPannerNode 104 104 0
WaveShaperNode 82 82 0

Baseline: 1e0fc6b817750ed3b2194d229f5dbb140e23815b · Candidate: 7732d656b5061066c383865fc0b97002314a8b72

Workflow run · this comment is updated on every push.

@mdydek mdydek added the feature New user-facing features or major capabilities label Sep 17, 2026
@mdydek
mdydek force-pushed the feat/workart-improvements branch from 9d6f1b7 to 80f1402 Compare September 18, 2026 10:40
@mdydek
mdydek marked this pull request as ready for review September 18, 2026 10:41
@github-actions github-actions Bot added the conflicts This PR has conflicts with the base branch. label Sep 22, 2026
@github-actions github-actions Bot removed the conflicts This PR has conflicts with the base branch. label Sep 24, 2026

@maciejmakowski2003 maciejmakowski2003 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdydek
mdydek merged commit 441da67 into main Oct 13, 2026
14 checks passed
@mdydek
mdydek deleted the feat/workart-improvements branch October 13, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New user-facing features or major capabilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] PlaybackNotification.loadArtwork decodes artwork at full resolution — unbounded memory, no cache, no timeouts

2 participants