Repository navigation
test(Reanimated): run the compiler API cases of the useDerivedValue tests and drop duplicate color rows - #11349
Conversation
… and drop duplicate color cases
|
No actionable comments were generated in the recent review. Walkthrough
Change: Other Merge Risk:
|
Note
This pull request was authored by AI on behalf of @bartlomiejbloniarz.
Summary
useDerivedValue/basic.test.tsxran every case twice, once withcompilerApi: true, but the test body always passedfalse. The 20 compiler API cases repeated the plain ones, and the compiler API path of that component was never run. Now the flag reaches the component, and the test names say which variant runs.withSequence/colors.test.tsxhad two rows listed twice. This PR drops the copies.Test plan
coreandanimationssuites of the reanimated runtime tests on an iOS simulator and an Android emulator. Both pass, including the compiler API cases.Changelog
yarn changelog:addfor each changed package, or this PR does not changereact-native-reanimatedorreact-native-worklets.AI context
Investigation
test.eachrows incore/useDerivedValue/basic.test.tsxare doubled withcompilerApi, but the callback destructured only{ startWidth, finalWidth, animate, animationType }and passed a literalfalsetogetSnapshotUpdatesAndCheckFinalValue.withSequence/colors.test.tsx: rowshwb(70, 50%, 0%) → hsl(120,100%,50%)andhwb(70, 50%, 0%) → rgb(101,255,50)(both with middlehsl(180, 50%, 50%)) appeared twice. Each row costs about 1.6 s.Scope
.get()/.set()inWidthComponent; the snapshots are the same as for.value.Verification
compilerApi: truepass on iOS and Android Debug Bundle Mode.