Skip to content

Allow SETs configuration to be updated on rerender - #5495

Merged
piaskowyk merged 34 commits into
mainfrom
@bartlomiejbloniarz/modify-sets
Mar 15, 2024
Merged

piaskowyk merged 34 commits into
mainfrom
@bartlomiejbloniarz/modify-sets

Conversation

@bartlomiejbloniarz

@bartlomiejbloniarz bartlomiejbloniarz commented Dec 13, 2023 •

Copy link
Copy Markdown
Member

Summary

This PR changes the current SETs implementation to allow for:

  • changes in configuration on rerender
  • tracking the changes in components on the hidden screen (the target snapshot is now created right before the hidden screen is shown)

Additional changes

In this PR I also changed the logic behind applying transforms to views in Snapshots on iOS. Now during the transition (so when the shared element is removed from it's parent) we apply a transform to the shared element, that is a combination of all the transforms that were applied by superviews before removing this element from its parent. I decided to do this in this PR, since those changes were closely tied to other changes I was already making in the iOS Snapshot logic. I, however, decided to not apply analogous changes on Android in this PR, because due to the API differences, the logic there would be too complicated, making this already humongous PR too big/dense.

TODO:

  • Android
  • isInteractive issues

Test plan

Check the behavior of [SET] Change theme example (and possibly all the other SET examples). Also on iOS check the [SET] Nested transforms example.

Base automatically changed from @bartlomiejbloniarz/modify-layout-animations to main January 15, 2024 09:50
@bartlomiejbloniarz
bartlomiejbloniarz force-pushed the @bartlomiejbloniarz/modify-sets branch from b54c2da to f3debe0 Compare January 15, 2024 11:17
@bartlomiejbloniarz
bartlomiejbloniarz marked this pull request as ready for review January 26, 2024 13:15
Comment thread apple/LayoutReanimation/REASnapshot.m Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants