Skip to content

refactor: unify tests in test apps - #2135

Merged
alduzy merged 10 commits into
mainfrom
@alduzy/unify-tests
May 27, 2024
Merged

alduzy merged 10 commits into
mainfrom
@alduzy/unify-tests

Conversation

@alduzy

@alduzy alduzy commented May 14, 2024

Copy link
Copy Markdown
Contributor

@alduzy
alduzy requested review from kkafar and tboba May 14, 2024 15:55
@alduzy
alduzy force-pushed the @alduzy/unify-tests branch from f12dcc6 to abcc595 Compare May 17, 2024 08:46
@alduzy
alduzy requested a review from maciekstosio May 20, 2024 08:55

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall. Left important remark

Comment thread FabricTestExample/App.js Resolved

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and there is one more thing. There could be some test cases that were present only in FabricTestExample and not in TestsExample or the other way around. Please make sure, that we do not remove them entirely.

@alduzy
alduzy requested a review from kkafar May 20, 2024 12:55

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks nice now 🎉

At last we need better name for the tests directory, as this is usually used in context of unit/integration tests and gives wrong clues about its contents. What do you think of test-screens or something similar?

Comment thread FabricTestExample/App.js Resolved
Comment thread TestsExample/App.js Resolved
@alduzy
alduzy requested a review from kkafar May 22, 2024 07:08

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go 🟢
If you tested & everything is working I think we can proceed.

ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

This PR intents to unify tests used by test apps

## Changes

- moved tests to common directory
- removed duplicates

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Updated documentation: <!-- For adding new props to native-stack
-->
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants