Repository navigation
refactor: unify tests in test apps - #2135
Merged
Merged
Conversation
2 tasks done
alduzy
force-pushed
the
@alduzy/unify-tests
branch
from
May 17, 2024 08:46
f12dcc6 to
abcc595
Compare
maciekstosio
approved these changes
May 20, 2024
kkafar
reviewed
May 20, 2024
kkafar
left a comment
Member
There was a problem hiding this comment.
Good job overall. Left important remark
kkafar
reviewed
May 20, 2024
kkafar
left a comment
Member
There was a problem hiding this comment.
Oh, and there is one more thing. There could be some test cases that were present only in FabricTestExample and not in TestsExample or the other way around. Please make sure, that we do not remove them entirely.
kkafar
reviewed
May 22, 2024
kkafar
left a comment
Member
There was a problem hiding this comment.
Yeah, it looks nice now 🎉
At last we need better name for the tests directory, as this is usually used in context of unit/integration tests and gives wrong clues about its contents. What do you think of test-screens or something similar?
alduzy
force-pushed
the
@alduzy/unify-tests
branch
from
May 22, 2024 09:19
27d56fc to
397e30f
Compare
kkafar
approved these changes
May 27, 2024
kkafar
left a comment
Member
There was a problem hiding this comment.
I think we're good to go 🟢
If you tested & everything is working I think we can proceed.
This was referenced Jul 17, 2024
This was referenced Aug 3, 2024
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR intents to unify tests used by test apps ## Changes - moved tests to common directory - removed duplicates <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to unify tests used by test apps
Changes
Test code and steps to reproduce
Checklist