Skip to content

chore(Android): update spotless & ktlint - #2189

Merged
kkafar merged 6 commits into
mainfrom
@kkafar/android-linter-2
Jun 19, 2024
Merged

kkafar merged 6 commits into
mainfrom
@kkafar/android-linter-2

Conversation

@kkafar

@kkafar kkafar commented Jun 17, 2024

Copy link
Copy Markdown
Member

Description

Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue.

Changes

Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22

Checklist

  • Ensured that CI passes

@kkafar
kkafar requested review from alduzy, maciekstosio and tboba and removed request for maciekstosio and tboba June 18, 2024 09:41

@tboba tboba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! Can we also put an update in this PR of distributionUrl field in main gradle-wrapper.properties file, so that we could bump gradle version here as well?

@kkafar

kkafar commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

Will do it in separate PR

@kkafar

kkafar commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

besides that it is already bumped to 7.5.1

@tboba

tboba commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

Yeah, I've seen that you've bumped it yesterday 😄 nevermind

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the code to make sure whether there are no semantics changes it all seems ok.

@kkafar
kkafar merged commit c018d75 into main Jun 19, 2024
@kkafar
kkafar deleted the @kkafar/android-linter-2 branch June 19, 2024 11:11
alduzy pushed a commit that referenced this pull request Jun 28, 2024
## Description

Encountered some errors (seems they were looking for old CMake version
(3.10.2)) & decided to bump these deps as they are long overdue.

## Changes

Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22

## Checklist

- [ ] Ensured that CI passes
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

Encountered some errors (seems they were looking for old CMake version
(3.10.2)) & decided to bump these deps as they are long overdue.

## Changes

Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants