Repository navigation
chore(Android): update spotless & ktlint - #2189
Merged
Merged
Conversation
kkafar
requested review from
alduzy,
maciekstosio and
tboba
and removed request for
maciekstosio and
tboba
June 18, 2024 09:41
tboba
approved these changes
Jun 18, 2024
tboba
left a comment
Contributor
There was a problem hiding this comment.
Great changes! Can we also put an update in this PR of distributionUrl field in main gradle-wrapper.properties file, so that we could bump gradle version here as well?
Member
Author
|
Will do it in separate PR |
Member
Author
|
besides that it is already bumped to 7.5.1 |
Contributor
|
Yeah, I've seen that you've bumped it yesterday 😄 nevermind |
kkafar
commented
Jun 19, 2024
kkafar
left a comment
Member
Author
There was a problem hiding this comment.
I skimmed through the code to make sure whether there are no semantics changes it all seems ok.
alduzy
pushed a commit
that referenced
this pull request
Jun 28, 2024
## Description Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue. ## Changes Ktlint: 0.43 -> 1.1.1 spotless 6.11 -> 6.22 ## Checklist - [ ] Ensured that CI passes
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 22, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue. ## Changes Ktlint: 0.43 -> 1.1.1 spotless 6.11 -> 6.22 ## Checklist - [ ] Ensured that CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue.
Changes
Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22
Checklist