Skip to content

chore: migrate examples to react-navigation v7 - #2194

Merged
alduzy merged 6 commits into
mainfrom
@alduzy/migrate-examples-to-navigation-v7
Jun 21, 2024
Merged

alduzy merged 6 commits into
mainfrom
@alduzy/migrate-examples-to-navigation-v7

Conversation

@alduzy

@alduzy alduzy commented Jun 18, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR intents to migrate examples to react-navigation v7.
Documentation: https://reactnavigation.org/docs/7.x/upgrading-from-6.x/

As for now I have only found two few files that needed changes. I ensured that nothing crashes in the example.

Changes

  • migrated navigating to nested screen
  • replaced navigate with popTo when explicitly going back to a specific screen
  • ensured nothing crashes

Test code and steps to reproduce

Checklist

  • Ensured that CI passes

@alduzy
alduzy requested review from WoLewicki, kkafar and tboba June 18, 2024 15:14
@alduzy
alduzy marked this pull request as draft June 19, 2024 15:23
@alduzy
alduzy marked this pull request as ready for review June 19, 2024 15:44

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if these are only examples that you detected to have problems we should proceed with merging.

We should just keep in mind, than when testing it might be possible that some tests require porting.

Going through every single example, testing it & wondering whether something needs to be ported is a waste of time for now. I'll write this to backlog, but rn let's move forward.

@alduzy
alduzy merged commit a955764 into main Jun 21, 2024
@alduzy
alduzy deleted the @alduzy/migrate-examples-to-navigation-v7 branch June 21, 2024 15:06
alduzy added a commit that referenced this pull request Jun 28, 2024
## Description

This PR intents to migrate examples to react-navigation v7.
Documentation: https://reactnavigation.org/docs/7.x/upgrading-from-6.x/

As for now I have only found ~~two~~ few files that needed changes. I
ensured that nothing crashes in the example.

## Changes

- migrated navigating to nested screen
- replaced `navigate` with `popTo` when explicitly going back to a
specific screen
- ensured nothing crashes

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

This PR intents to migrate examples to react-navigation v7.
Documentation: https://reactnavigation.org/docs/7.x/upgrading-from-6.x/

As for now I have only found ~~two~~ few files that needed changes. I
ensured that nothing crashes in the example.

## Changes

- migrated navigating to nested screen
- replaced `navigate` with `popTo` when explicitly going back to a
specific screen
- ensured nothing crashes

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants