Skip to content

refact(Android): rename compareFrameSizes to checkFrameSizesEqualWithEps - #2217

Merged
kkafar merged 1 commit into
mainfrom
@kkafar/rename-compareframesizes
Jun 27, 2024
Merged

kkafar merged 1 commit into
mainfrom
@kkafar/rename-compareframesizes

Conversation

@kkafar

@kkafar kkafar commented Jun 27, 2024

Copy link
Copy Markdown
Member

Description

As suggested by @alduzy, new the new function name should better convey its behaviour.
Old came compareFrameSizes could suggest inequality.

Changes

Renamed compareFrameSizes to checkFrameSizesEqualWithEps.

Test code and steps to reproduce

Android should build on Fabric => CI

Checklist

  • Ensured that CI passes

@kkafar
kkafar merged commit a9bc111 into main Jun 27, 2024
@kkafar
kkafar deleted the @kkafar/rename-compareframesizes branch June 27, 2024 12:08
alduzy pushed a commit that referenced this pull request Jun 28, 2024
…ithEps` (#2217)

## Description

As suggested by @alduzy, new the new function name should better convey
its behaviour.
Old came `compareFrameSizes` could suggest inequality.

## Changes

Renamed `compareFrameSizes` to `checkFrameSizesEqualWithEps`.

## Test code and steps to reproduce

Android should build on Fabric => CI

## Checklist

- [ ] Ensured that CI passes
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…ithEps` (software-mansion#2217)

## Description

As suggested by @alduzy, new the new function name should better convey
its behaviour.
Old came `compareFrameSizes` could suggest inequality.

## Changes

Renamed `compareFrameSizes` to `checkFrameSizesEqualWithEps`.

## Test code and steps to reproduce

Android should build on Fabric => CI

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants